trivial: Replace some qemu_open_old() with qemu_open()

[PATCH 5/7] backends/hostmem-epc: Get rid of qemu_open_old()

Posted by Zhao Liu 4 months, 1 week ago

For qemu_open_old(), osdep.h said:

> Don't introduce new usage of this function, prefer the following
> qemu_open/qemu_create that take an "Error **errp".

So replace qemu_open_old() with qemu_open().

Cc: David Hildenbrand <david@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
 backends/hostmem-epc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/backends/hostmem-epc.c b/backends/hostmem-epc.c
index f58fcf00a10b..6c024d6217d2 100644
--- a/backends/hostmem-epc.c
+++ b/backends/hostmem-epc.c
@@ -29,10 +29,8 @@ sgx_epc_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
         return false;
     }
 
-    fd = qemu_open_old("/dev/sgx_vepc", O_RDWR);
+    fd = qemu_open("/dev/sgx_vepc", O_RDWR, errp);
     if (fd < 0) {
-        error_setg_errno(errp, errno,
-                         "failed to open /dev/sgx_vepc to alloc SGX EPC");
         return false;
     }
 
-- 
2.34.1

Re: [PATCH 5/7] backends/hostmem-epc: Get rid of qemu_open_old()

Posted by Igor Mammedov 4 months, 1 week ago

On Mon, 15 Jul 2024 16:21:53 +0800
Zhao Liu <zhao1.liu@intel.com> wrote:

> For qemu_open_old(), osdep.h said:
> 
> > Don't introduce new usage of this function, prefer the following
> > qemu_open/qemu_create that take an "Error **errp".  
> 
> So replace qemu_open_old() with qemu_open().
> 
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  backends/hostmem-epc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/backends/hostmem-epc.c b/backends/hostmem-epc.c
> index f58fcf00a10b..6c024d6217d2 100644
> --- a/backends/hostmem-epc.c
> +++ b/backends/hostmem-epc.c
> @@ -29,10 +29,8 @@ sgx_epc_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
>          return false;
>      }
>  
> -    fd = qemu_open_old("/dev/sgx_vepc", O_RDWR);
> +    fd = qemu_open("/dev/sgx_vepc", O_RDWR, errp);
>      if (fd < 0) {
> -        error_setg_errno(errp, errno,
> -                         "failed to open /dev/sgx_vepc to alloc SGX EPC");
>          return false;
>      }
>

Re: [PATCH 5/7] backends/hostmem-epc: Get rid of qemu_open_old()

Posted by Philippe Mathieu-Daudé 4 months, 1 week ago

On 15/7/24 10:21, Zhao Liu wrote:
> For qemu_open_old(), osdep.h said:
> 
>> Don't introduce new usage of this function, prefer the following
>> qemu_open/qemu_create that take an "Error **errp".
> 
> So replace qemu_open_old() with qemu_open().
> 
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>   backends/hostmem-epc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

[PATCH 1/7] hw/i386/sgx: Get rid of qemu_open_old()
[PATCH 2/7] hw/usb/host-libusb: Get rid of qemu_open_old()
[PATCH 3/7] hw/usb/u2f-passthru: Get rid of qemu_open_old()
[PATCH 4/7] hw/vfio/container: Get rid of qemu_open_old()
[PATCH 5/7] backends/hostmem-epc: Get rid of qemu_open_old()
[PATCH 6/7] backends/iommufd: Get rid of qemu_open_old()
[PATCH 7/7] backends/rng-random: Get rid of qemu_open_old()