trivial: Replace some qemu_open_old() with qemu_open()

[PATCH 3/7] hw/usb/u2f-passthru: Get rid of qemu_open_old()

Zhao Liu posted 7 patches 4 months, 1 week ago

Download mbox

Maintainers: David Hildenbrand <david@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Yi Liu <yi.l.liu@intel.com>, Eric Auger <eric.auger@redhat.com>, Zhenzhong Duan <zhenzhong.duan@intel.com>, Laurent Vivier <lvivier@redhat.com>, Amit Shah <amit@kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, Alex Williamson <alex.williamson@redhat.com>, "Cédric Le Goater" <clg@redhat.com>

Expand all Fold all

[PATCH 3/7] hw/usb/u2f-passthru: Get rid of qemu_open_old()

Posted by Zhao Liu 4 months, 1 week ago

For qemu_open_old(), osdep.h said:

> Don't introduce new usage of this function, prefer the following
> qemu_open/qemu_create that take an "Error **errp".

So replace qemu_open_old() with qemu_open().

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
 hw/usb/u2f-passthru.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/hw/usb/u2f-passthru.c b/hw/usb/u2f-passthru.c
index b7025d303d07..c4a783d12864 100644
--- a/hw/usb/u2f-passthru.c
+++ b/hw/usb/u2f-passthru.c
@@ -482,10 +482,8 @@ static void u2f_passthru_realize(U2FKeyState *base, Error **errp)
         return;
 #endif
     } else {
-        fd = qemu_open_old(key->hidraw, O_RDWR);
+        fd = qemu_open(key->hidraw, O_RDWR, errp);
         if (fd < 0) {
-            error_setg(errp, "%s: Failed to open %s", TYPE_U2F_PASSTHRU,
-                       key->hidraw);
             return;
         }
 
-- 
2.34.1

Re: [PATCH 3/7] hw/usb/u2f-passthru: Get rid of qemu_open_old()

Posted by Philippe Mathieu-Daudé 4 months, 1 week ago

On 15/7/24 10:21, Zhao Liu wrote:
> For qemu_open_old(), osdep.h said:
> 
>> Don't introduce new usage of this function, prefer the following
>> qemu_open/qemu_create that take an "Error **errp".
> 
> So replace qemu_open_old() with qemu_open().
> 
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>   hw/usb/u2f-passthru.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

[PATCH 1/7] hw/i386/sgx: Get rid of qemu_open_old()
[PATCH 2/7] hw/usb/host-libusb: Get rid of qemu_open_old()
[PATCH 3/7] hw/usb/u2f-passthru: Get rid of qemu_open_old()
[PATCH 4/7] hw/vfio/container: Get rid of qemu_open_old()
[PATCH 5/7] backends/hostmem-epc: Get rid of qemu_open_old()
[PATCH 6/7] backends/iommufd: Get rid of qemu_open_old()
[PATCH 7/7] backends/rng-random: Get rid of qemu_open_old()