system: Enable the device aliases for or1k, too

[PATCH] system: Enable the device aliases for or1k, too

Posted by Thomas Huth 4 months, 3 weeks ago

Now that we've got a "virt" machine for or1k that supports PCI, too,
we can also enable the virtio device aliases like we do on other
similar platforms. This will e.g. help to run the iotests with
qemu-system-or1k later.

While we're at it, sort QEMU_ARCH_LOONGARCH alphabetically into
the list.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 system/qdev-monitor.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c
index 6af6ef7d66..60c3b6ad96 100644
--- a/system/qdev-monitor.c
+++ b/system/qdev-monitor.c
@@ -57,10 +57,10 @@ typedef struct QDevAlias
 /* default virtio transport per architecture */
 #define QEMU_ARCH_VIRTIO_PCI (QEMU_ARCH_ALPHA | QEMU_ARCH_ARM | \
                               QEMU_ARCH_HPPA | QEMU_ARCH_I386 | \
-                              QEMU_ARCH_MIPS | QEMU_ARCH_PPC |  \
+                              QEMU_ARCH_LOONGARCH | QEMU_ARCH_MIPS | \
+                              QEMU_ARCH_OPENRISC | QEMU_ARCH_PPC | \
                               QEMU_ARCH_RISCV | QEMU_ARCH_SH4 | \
-                              QEMU_ARCH_SPARC | QEMU_ARCH_XTENSA | \
-                              QEMU_ARCH_LOONGARCH)
+                              QEMU_ARCH_SPARC | QEMU_ARCH_XTENSA)
 #define QEMU_ARCH_VIRTIO_CCW (QEMU_ARCH_S390X)
 #define QEMU_ARCH_VIRTIO_MMIO (QEMU_ARCH_M68K)
 
-- 
2.45.2

Re: [PATCH] system: Enable the device aliases for or1k, too

Posted by Philippe Mathieu-Daudé 4 months, 3 weeks ago

On 5/7/24 11:08, Thomas Huth wrote:
> Now that we've got a "virt" machine for or1k that supports PCI, too,
> we can also enable the virtio device aliases like we do on other
> similar platforms. This will e.g. help to run the iotests with
> qemu-system-or1k later.

Indeed, since 2022 in commit 40fef82c4e ("hw/openrisc:
Add PCI bus support to virt").

> 
> While we're at it, sort QEMU_ARCH_LOONGARCH alphabetically into
> the list.

Suggestion: a preliminary patch sorting 1 arch per line ;)

> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   system/qdev-monitor.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] system: Enable the device aliases for or1k, too

Posted by Philippe Mathieu-Daudé 4 months, 3 weeks ago

On 5/7/24 14:39, Philippe Mathieu-Daudé wrote:
> On 5/7/24 11:08, Thomas Huth wrote:
>> Now that we've got a "virt" machine for or1k that supports PCI, too,
>> we can also enable the virtio device aliases like we do on other
>> similar platforms. This will e.g. help to run the iotests with
>> qemu-system-or1k later.
> 
> Indeed, since 2022 in commit 40fef82c4e ("hw/openrisc:
> Add PCI bus support to virt").
> 
>>
>> While we're at it, sort QEMU_ARCH_LOONGARCH alphabetically into
>> the list.
> 
> Suggestion: a preliminary patch sorting 1 arch per line ;)

Done here:
https://lore.kernel.org/qemu-devel/20240705124528.97471-1-philmd@linaro.org/

> 
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>   system/qdev-monitor.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>