1. Patchew
  2. QEMU
  3. [PATCH 0/4] trivial: Fix superfluous trailing semicolon
  4. View patch

[PATCH 4/4] target/hexagon/imported/mmvec: Fix superfluous trailing semicolon

Zhao Liu posted 4 patches 4 months, 3 weeks ago
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Brian Cain <bcain@quicinc.com>
[PATCH 4/4] target/hexagon/imported/mmvec: Fix superfluous trailing semicolon
Posted by Zhao Liu 4 months, 3 weeks ago 
Fix the superfluous trailing semicolon in target/hexagon/imported/mmvec/
ext.idef.

Cc: Brian Cain <bcain@quicinc.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
 target/hexagon/imported/mmvec/ext.idef | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/hexagon/imported/mmvec/ext.idef b/target/hexagon/imported/mmvec/ext.idef
index 98daabfb07c4..03d31f6181d7 100644
--- a/target/hexagon/imported/mmvec/ext.idef
+++ b/target/hexagon/imported/mmvec/ext.idef
@@ -2855,7 +2855,7 @@ EXTINSN(V6_vscattermhw_add,  "vscatter(Rt32,Mu2,Vvv32.w).h+=Vw32", ATTRIBS(A_EXT
     fVALIGN(RtV, element_size);
     fVFOREACH(32, i) {
         for(j = 0; j < 2; j++) {
-             EA =  RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT);;
+             EA =  RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT);
              fVLOG_VTCM_HALFWORD_INCREMENT_DV(EA,VvvV.v[j].uw[i],VwV,(2*i+j),i,j,ALIGNMENT,MuV);
         }
     }
-- 
2.34.1
Re: [PATCH 4/4] target/hexagon/imported/mmvec: Fix superfluous trailing semicolon
Posted by Brian Cain 4 months, 3 weeks ago 
On 7/4/2024 3:47 AM, Zhao Liu wrote:
> Fix the superfluous trailing semicolon in target/hexagon/imported/mmvec/
> ext.idef.
>
> Cc: Brian Cain <bcain@quicinc.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>

Reviewed-by: Brian Cain <bcain@quicinc.com>


> ---
>   target/hexagon/imported/mmvec/ext.idef | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/hexagon/imported/mmvec/ext.idef b/target/hexagon/imported/mmvec/ext.idef
> index 98daabfb07c4..03d31f6181d7 100644
> --- a/target/hexagon/imported/mmvec/ext.idef
> +++ b/target/hexagon/imported/mmvec/ext.idef
> @@ -2855,7 +2855,7 @@ EXTINSN(V6_vscattermhw_add,  "vscatter(Rt32,Mu2,Vvv32.w).h+=Vw32", ATTRIBS(A_EXT
>       fVALIGN(RtV, element_size);
>       fVFOREACH(32, i) {
>           for(j = 0; j < 2; j++) {
> -             EA =  RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT);;
> +             EA =  RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT);
>                fVLOG_VTCM_HALFWORD_INCREMENT_DV(EA,VvvV.v[j].uw[i],VwV,(2*i+j),i,j,ALIGNMENT,MuV);
>           }
>       }
Re: [PATCH 4/4] target/hexagon/imported/mmvec: Fix superfluous trailing semicolon
Posted by Michael Tokarev 4 months, 1 week ago 
06.07.2024 00:50, Brian Cain wrote:
> 
> On 7/4/2024 3:47 AM, Zhao Liu wrote:
>> Fix the superfluous trailing semicolon in target/hexagon/imported/mmvec/
>> ext.idef.
>>
>> Cc: Brian Cain <bcain@quicinc.com>
>> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> 
> Reviewed-by: Brian Cain <bcain@quicinc.com>

Brian, is it okay to fix this in something "imported" ?
I realize you added your R-b, but do you realize it's "imported"?

Thanks,

/mjt

>> ---
>>   target/hexagon/imported/mmvec/ext.idef | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/hexagon/imported/mmvec/ext.idef b/target/hexagon/imported/mmvec/ext.idef
>> index 98daabfb07c4..03d31f6181d7 100644
>> --- a/target/hexagon/imported/mmvec/ext.idef
>> +++ b/target/hexagon/imported/mmvec/ext.idef
>> @@ -2855,7 +2855,7 @@ EXTINSN(V6_vscattermhw_add,  "vscatter(Rt32,Mu2,Vvv32.w).h+=Vw32", ATTRIBS(A_EXT
>>       fVALIGN(RtV, element_size);
>>       fVFOREACH(32, i) {
>>           for(j = 0; j < 2; j++) {
>> -             EA =  RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT);;
>> +             EA =  RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT);
>>                fVLOG_VTCM_HALFWORD_INCREMENT_DV(EA,VvvV.v[j].uw[i],VwV,(2*i+j),i,j,ALIGNMENT,MuV);
>>           }
>>       }
>
Re: [PATCH 4/4] target/hexagon/imported/mmvec: Fix superfluous trailing semicolon
Posted by Brian Cain 4 months, 1 week ago 
On 7/15/2024 4:59 AM, Michael Tokarev wrote:
> 06.07.2024 00:50, Brian Cain wrote:
>>
>> On 7/4/2024 3:47 AM, Zhao Liu wrote:
>>> Fix the superfluous trailing semicolon in 
>>> target/hexagon/imported/mmvec/
>>> ext.idef.
>>>
>>> Cc: Brian Cain <bcain@quicinc.com>
>>> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
>>
>> Reviewed-by: Brian Cain <bcain@quicinc.com>
>
> Brian, is it okay to fix this in something "imported" ?
> I realize you added your R-b, but do you realize it's "imported"?
>
Sure, it's fine - I'll just have to take extra care not to re-introduce 
issues like these when making updates.  I can try and work with the 
original sources to make sure it's addressed there.


> Thanks,
>
> /mjt
>
>>> ---
>>>   target/hexagon/imported/mmvec/ext.idef | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/target/hexagon/imported/mmvec/ext.idef 
>>> b/target/hexagon/imported/mmvec/ext.idef
>>> index 98daabfb07c4..03d31f6181d7 100644
>>> --- a/target/hexagon/imported/mmvec/ext.idef
>>> +++ b/target/hexagon/imported/mmvec/ext.idef
>>> @@ -2855,7 +2855,7 @@ EXTINSN(V6_vscattermhw_add, 
>>> "vscatter(Rt32,Mu2,Vvv32.w).h+=Vw32", ATTRIBS(A_EXT
>>>       fVALIGN(RtV, element_size);
>>>       fVFOREACH(32, i) {
>>>           for(j = 0; j < 2; j++) {
>>> -             EA =  RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT);;
>>> +             EA =  RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT);
>>> fVLOG_VTCM_HALFWORD_INCREMENT_DV(EA,VvvV.v[j].uw[i],VwV,(2*i+j),i,j,ALIGNMENT,MuV);
>>>           }
>>>       }
>>
>
Re: [PATCH 4/4] target/hexagon/imported/mmvec: Fix superfluous trailing semicolon
Posted by Alex Bennée 4 months, 3 weeks ago 
Zhao Liu <zhao1.liu@intel.com> writes:

> Fix the superfluous trailing semicolon in target/hexagon/imported/mmvec/
> ext.idef.
>
> Cc: Brian Cain <bcain@quicinc.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro
Re: [PATCH 4/4] target/hexagon/imported/mmvec: Fix superfluous trailing semicolon
Posted by Peter Maydell 4 months, 3 weeks ago 
On Thu, 4 Jul 2024 at 09:33, Zhao Liu <zhao1.liu@intel.com> wrote:
>
> Fix the superfluous trailing semicolon in target/hexagon/imported/mmvec/
> ext.idef.
>
> Cc: Brian Cain <bcain@quicinc.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>  target/hexagon/imported/mmvec/ext.idef | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/hexagon/imported/mmvec/ext.idef b/target/hexagon/imported/mmvec/ext.idef
> index 98daabfb07c4..03d31f6181d7 100644
> --- a/target/hexagon/imported/mmvec/ext.idef
> +++ b/target/hexagon/imported/mmvec/ext.idef
> @@ -2855,7 +2855,7 @@ EXTINSN(V6_vscattermhw_add,  "vscatter(Rt32,Mu2,Vvv32.w).h+=Vw32", ATTRIBS(A_EXT
>      fVALIGN(RtV, element_size);
>      fVFOREACH(32, i) {
>          for(j = 0; j < 2; j++) {
> -             EA =  RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT);;
> +             EA =  RtV + fVALIGN(VvvV.v[j].uw[i],ALIGNMENT);
>               fVLOG_VTCM_HALFWORD_INCREMENT_DV(EA,VvvV.v[j].uw[i],VwV,(2*i+j),i,j,ALIGNMENT,MuV);
>          }
>      }
> --
> 2.34.1

As a change this is obviously fine, but given the "imported"
in the pathname I don't know if this is something that should
be fixed in whatever upstream source we got this from instead
or as well. Brian ?

thanks
-- PMM

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.