qapi/qom: Document feature unstable of @x-vfio-user-server

[PATCH] qapi/qom: Document feature unstable of @x-vfio-user-server

Posted by Markus Armbruster 4 months, 3 weeks ago

Commit 8f9a9259d32c added ObjectType member @x-vfio-user-server with
feature unstable, but neglected to explain why it is unstable.  Do
that now.

Fixes: 8f9a9259d32c (vfio-user: define vfio-user-server object)
Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>
Cc: John G Johnson <john.g.johnson@oracle.com>
Cc: Jagannathan Raman <jag.raman@oracle.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qapi/qom.json | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/qapi/qom.json b/qapi/qom.json
index 8bd299265e..3c0f8c633d 100644
--- a/qapi/qom.json
+++ b/qapi/qom.json
@@ -1012,7 +1012,8 @@
 #
 # Features:
 #
-# @unstable: Member @x-remote-object is experimental.
+# @unstable: Members @x-remote-object and @x-vfio-user-server are
+# experimental.
 #
 # Since: 6.0
 ##
-- 
2.45.0

Re: [PATCH] qapi/qom: Document feature unstable of @x-vfio-user-server

Posted by Markus Armbruster 4 months, 1 week ago

Markus Armbruster <armbru@redhat.com> writes:

> Commit 8f9a9259d32c added ObjectType member @x-vfio-user-server with
> feature unstable, but neglected to explain why it is unstable.  Do
> that now.
>
> Fixes: 8f9a9259d32c (vfio-user: define vfio-user-server object)
> Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> Cc: John G Johnson <john.g.johnson@oracle.com>
> Cc: Jagannathan Raman <jag.raman@oracle.com>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qapi/qom.json | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/qom.json b/qapi/qom.json
> index 8bd299265e..3c0f8c633d 100644
> --- a/qapi/qom.json
> +++ b/qapi/qom.json
> @@ -1012,7 +1012,8 @@
>  #
>  # Features:
>  #
> -# @unstable: Member @x-remote-object is experimental.
> +# @unstable: Members @x-remote-object and @x-vfio-user-server are
> +# experimental.

Second line needs to be indented.  Fixed in my tree.

>  #
>  # Since: 6.0
>  ##

Queued.

Re: [PATCH] qapi/qom: Document feature unstable of @x-vfio-user-server

Posted by John Snow 4 months, 3 weeks ago

On Wed, Jul 3, 2024 at 5:53 AM Markus Armbruster <armbru@redhat.com> wrote:

> Commit 8f9a9259d32c added ObjectType member @x-vfio-user-server with
> feature unstable, but neglected to explain why it is unstable.  Do
> that now.
>
> Fixes: 8f9a9259d32c (vfio-user: define vfio-user-server object)
> Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> Cc: John G Johnson <john.g.johnson@oracle.com>
> Cc: Jagannathan Raman <jag.raman@oracle.com>
> Cc: qemu-stable@nongnu.org


Reported-by: John Snow <jsnow@redhat.com>

(... This is a joke, to be extremely clear)


>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>

Reviewed-by: John Snow <jsnow@redhat.com>


> ---
>  qapi/qom.json | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/qom.json b/qapi/qom.json
> index 8bd299265e..3c0f8c633d 100644
> --- a/qapi/qom.json
> +++ b/qapi/qom.json
> @@ -1012,7 +1012,8 @@
>  #
>  # Features:
>  #
> -# @unstable: Member @x-remote-object is experimental.
> +# @unstable: Members @x-remote-object and @x-vfio-user-server are
> +# experimental.
>  #
>  # Since: 6.0
>  ##
> --
> 2.45.0
>
>