[PATCH v45 1/3] hw/sd/sdcard: Remove leftover comment about removed 'spi' Property

Philippe Mathieu-Daudé posted 3 patches 4 months, 3 weeks ago
Maintainers: Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>, Bin Meng <bmeng.cn@gmail.com>
There is a newer version of this series
[PATCH v45 1/3] hw/sd/sdcard: Remove leftover comment about removed 'spi' Property
Posted by Philippe Mathieu-Daudé 4 months, 3 weeks ago
Commit c3287c0f70 ("hw/sd: Introduce a "sd-card" SPI variant
model") removed the 'spi' property. Remove the comment left
over.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/sd/sd.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index b158402704..53767beaf8 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -2473,10 +2473,6 @@ static Property sd_properties[] = {
     DEFINE_PROP_UINT8("spec_version", SDState,
                       spec_version, SD_PHY_SPECv2_00_VERS),
     DEFINE_PROP_DRIVE("drive", SDState, blk),
-    /* We do not model the chip select pin, so allow the board to select
-     * whether card should be in SSI or MMC/SD mode.  It is also up to the
-     * board to ensure that ssi transfers only occur when the chip select
-     * is asserted.  */
     DEFINE_PROP_END_OF_LIST()
 };
 
-- 
2.41.0


Re: [PATCH v45 1/3] hw/sd/sdcard: Remove leftover comment about removed 'spi' Property
Posted by Manos Pitsidianakis 4 months, 3 weeks ago
On Wed, 03 Jul 2024 11:59, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>Commit c3287c0f70 ("hw/sd: Introduce a "sd-card" SPI variant
>model") removed the 'spi' property. Remove the comment left
>over.
>
>Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>---
> hw/sd/sd.c | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/hw/sd/sd.c b/hw/sd/sd.c
>index b158402704..53767beaf8 100644
>--- a/hw/sd/sd.c
>+++ b/hw/sd/sd.c
>@@ -2473,10 +2473,6 @@ static Property sd_properties[] = {
>     DEFINE_PROP_UINT8("spec_version", SDState,
>                       spec_version, SD_PHY_SPECv2_00_VERS),
>     DEFINE_PROP_DRIVE("drive", SDState, blk),
>-    /* We do not model the chip select pin, so allow the board to select
>-     * whether card should be in SSI or MMC/SD mode.  It is also up to the
>-     * board to ensure that ssi transfers only occur when the chip select
>-     * is asserted.  */
>     DEFINE_PROP_END_OF_LIST()
> };
> 
>-- 
>2.41.0
>
>

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>