[v4] virtio-pci: Fix the use of an uninitialized irqfd

[PATCH v4 0/2] virtio-pci: Fix the use of an uninitialized irqfd

Cindy Lu posted 2 patches 2 months, 1 week ago

Diff against v3 v5 v6
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240702020033.139261-1-lulu@redhat.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>

There is a newer version of this series

hw/virtio/virtio-pci.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH v4 0/2] virtio-pci: Fix the use of an uninitialized irqfd

Posted by Cindy Lu 2 months, 1 week ago

The crash was reported in MAC OS and NixOS, here is the link for this bug
https://gitlab.com/qemu-project/qemu/-/issues/2334
https://gitlab.com/qemu-project/qemu/-/issues/2321

changelog v4 -> v3
 - Address the comments in V3
 - sperate the return check in kvm_virtio_pci_vector_use_one()
   in different patch
changelog v3 -> v2
 - Move the vector_irqfd check to virtio_pci_get_notifier().
   This function can also be used while vdev->status is not VIRTIO_CONFIG_S_DRIVER_OK.
   In that case, the vector_irqfd could be NULL, so also add the status check here.
 - Add the return value check for kvm_virtio_pci_vector_use_one().
   Since the return value of function virtio_pci_set_vector() is void,
   just add the error message here.

Cindy Lu (2):
  virtio-pci: Fix the use of an uninitialized irqfd
  virtio-pci: Add check the return of kvm_virtio_pci_vector_use_one

 hw/virtio/virtio-pci.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

-- 
2.45.0