On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Thanks,
C.
> ---
> hw/sd/sd.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 097cb0f2e2..74aa38a442 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -243,12 +243,12 @@ static const char *sd_cmd_name(SDState *sd, uint8_t cmd)
> [5] = "IO_SEND_OP_COND",
> [6] = "SWITCH_FUNC", [7] = "SELECT/DESELECT_CARD",
> [8] = "SEND_IF_COND", [9] = "SEND_CSD",
> - [10] = "SEND_CID", [11] = "VOLTAGE_SWITCH",
> + [10] = "SEND_CID",
> [12] = "STOP_TRANSMISSION", [13] = "SEND_STATUS",
> [15] = "GO_INACTIVE_STATE",
> [16] = "SET_BLOCKLEN", [17] = "READ_SINGLE_BLOCK",
> [18] = "READ_MULTIPLE_BLOCK",
> - [20] = "SPEED_CLASS_CONTROL", [21] = "DPS_spec",
> + [21] = "DPS_spec",
> [24] = "WRITE_BLOCK", [25] = "WRITE_MULTIPLE_BLOCK",
> [26] = "MANUF_RSVD", [27] = "PROGRAM_CSD",
> [28] = "SET_WRITE_PROT", [29] = "CLR_WRITE_PROT",
> @@ -1161,6 +1161,14 @@ static sd_rsp_type_t sd_cmd_unimplemented(SDState *sd, SDRequest req)
> return sd_illegal;
> }
>
> +static sd_rsp_type_t sd_cmd_optional(SDState *sd, SDRequest req)
> +{
> + qemu_log_mask(LOG_UNIMP, "%s: Optional CMD%i not implemented\n",
> + sd->proto->name, req.cmd);
> +
> + return sd_illegal;
> +}
> +
> /* Configure fields for following sd_generic_write_byte() calls */
> static sd_rsp_type_t sd_cmd_to_receivingdata(SDState *sd, SDRequest req,
> uint64_t start, size_t size)
> @@ -2279,7 +2287,9 @@ static const SDProto sd_proto_sd = {
> [2] = {0, sd_bcr, "ALL_SEND_CID", sd_cmd_ALL_SEND_CID},
> [3] = {0, sd_bcr, "SEND_RELATIVE_ADDR", sd_cmd_SEND_RELATIVE_ADDR},
> [4] = {0, sd_bc, "SEND_DSR", sd_cmd_unimplemented},
> + [11] = {0, sd_ac, "VOLTAGE_SWITCH", sd_cmd_optional},
> [19] = {2, sd_adtc, "SEND_TUNING_BLOCK", sd_cmd_SEND_TUNING_BLOCK},
> + [20] = {2, sd_ac, "SPEED_CLASS_CONTROL", sd_cmd_optional},
> [23] = {2, sd_ac, "SET_BLOCK_COUNT", sd_cmd_SET_BLOCK_COUNT},
> },
> };