block/graph-lock: Make WITH_GRAPH_RDLOCK_GUARD() fully checked

[PATCH 0/2] block/graph-lock: Make WITH_GRAPH_RDLOCK_GUARD() fully checked

Kevin Wolf posted 2 patches 5 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240627181245.281403-1-kwolf@redhat.com

Maintainers: John Snow <jsnow@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Thomas Huth <thuth@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>

include/block/graph-lock.h | 21 ++++++++++++++-------
block/block-copy.c         |  4 +++-
meson.build                | 14 +++++++++++++-
3 files changed, 30 insertions(+), 9 deletions(-)

Expand all Fold all

[PATCH 0/2] block/graph-lock: Make WITH_GRAPH_RDLOCK_GUARD() fully checked

Posted by Kevin Wolf 5 months ago

Newer clang versions allow us to check scoped guards more thoroughly.
Surprisingly, we only seem to have missed one instance with the old
incomplete checks.

Kevin Wolf (2):
  block-copy: Fix missing graph lock
  block/graph-lock: Make WITH_GRAPH_RDLOCK_GUARD() fully checked

 include/block/graph-lock.h | 21 ++++++++++++++-------
 block/block-copy.c         |  4 +++-
 meson.build                | 14 +++++++++++++-
 3 files changed, 30 insertions(+), 9 deletions(-)

-- 
2.45.2

Re: [PATCH 0/2] block/graph-lock: Make WITH_GRAPH_RDLOCK_GUARD() fully checked

Posted by Stefan Hajnoczi 4 months, 2 weeks ago

On Thu, Jun 27, 2024 at 08:12:43PM +0200, Kevin Wolf wrote:
> Newer clang versions allow us to check scoped guards more thoroughly.
> Surprisingly, we only seem to have missed one instance with the old
> incomplete checks.
> 
> Kevin Wolf (2):
>   block-copy: Fix missing graph lock
>   block/graph-lock: Make WITH_GRAPH_RDLOCK_GUARD() fully checked
> 
>  include/block/graph-lock.h | 21 ++++++++++++++-------
>  block/block-copy.c         |  4 +++-
>  meson.build                | 14 +++++++++++++-
>  3 files changed, 30 insertions(+), 9 deletions(-)
> 
> -- 
> 2.45.2
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>