[v1] tests/tcg/aarch64: Fix inline assemblies for clang

[PATCH 0/6] tests/tcg/aarch64: Fix inline assemblies for clang

Akihiko Odaki posted 6 patches 5 months ago

Diff against v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240626-tcg-v1-0-0bad656307d8@daynix.com

Maintainers: Peter Maydell <peter.maydell@linaro.org>

There is a newer version of this series

tests/tcg/aarch64/bti-1.c         |   6 +-
tests/tcg/aarch64/bti-3.c         |   6 +-
tests/tcg/aarch64/mte-1.c         |   2 +-
tests/tcg/aarch64/sme-smopa-2.c   |   2 +-
tests/tcg/arm/fcvt.c              |  20 +-
tests/tcg/aarch64/Makefile.target |  12 +-
tests/tcg/aarch64/fcvt.ref        | 604 +++++++++++++++++++-------------------
7 files changed, 331 insertions(+), 321 deletions(-)

Expand all Fold all

[PATCH 0/6] tests/tcg/aarch64: Fix inline assemblies for clang

Posted by Akihiko Odaki 5 months ago

Unlike GCC, clang checks if the operands in assembly matches with the
type in C. It also does not support "x" constraint for AArch64 and
complains about them.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
Akihiko Odaki (6):
      tests/tcg/arm: Fix fcvt result messages
      tests/tcg/aarch64: Fix test architecture specification
      tests/tcg/aarch64: Explicitly specify register width
      tests/tcg/aarch64: Fix irg operand type
      tests/tcg/aarch64: Do not use x constraint
      tests/tcg/arm: Manually bit-cast half-precision numbers

 tests/tcg/aarch64/bti-1.c         |   6 +-
 tests/tcg/aarch64/bti-3.c         |   6 +-
 tests/tcg/aarch64/mte-1.c         |   2 +-
 tests/tcg/aarch64/sme-smopa-2.c   |   2 +-
 tests/tcg/arm/fcvt.c              |  20 +-
 tests/tcg/aarch64/Makefile.target |  12 +-
 tests/tcg/aarch64/fcvt.ref        | 604 +++++++++++++++++++-------------------
 7 files changed, 331 insertions(+), 321 deletions(-)
---
base-commit: 74abb45dac6979e7ff76172b7f0a24e869405184
change-id: 20240624-tcg-bf8116e80afa

Best regards,
-- 
Akihiko Odaki <akihiko.odaki@daynix.com>

Re: [PATCH 0/6] tests/tcg/aarch64: Fix inline assemblies for clang

Posted by Alex Bennée 5 months ago

Akihiko Odaki <akihiko.odaki@daynix.com> writes:

> Unlike GCC, clang checks if the operands in assembly matches with the
> type in C. It also does not support "x" constraint for AArch64 and
> complains about them.

When are the test cases ever built with clang? Is this for Arm on Arm
testing only?

>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> Akihiko Odaki (6):
>       tests/tcg/arm: Fix fcvt result messages
>       tests/tcg/aarch64: Fix test architecture specification
>       tests/tcg/aarch64: Explicitly specify register width
>       tests/tcg/aarch64: Fix irg operand type
>       tests/tcg/aarch64: Do not use x constraint
>       tests/tcg/arm: Manually bit-cast half-precision numbers
>
>  tests/tcg/aarch64/bti-1.c         |   6 +-
>  tests/tcg/aarch64/bti-3.c         |   6 +-
>  tests/tcg/aarch64/mte-1.c         |   2 +-
>  tests/tcg/aarch64/sme-smopa-2.c   |   2 +-
>  tests/tcg/arm/fcvt.c              |  20 +-
>  tests/tcg/aarch64/Makefile.target |  12 +-
>  tests/tcg/aarch64/fcvt.ref        | 604 +++++++++++++++++++-------------------
>  7 files changed, 331 insertions(+), 321 deletions(-)
> ---
> base-commit: 74abb45dac6979e7ff76172b7f0a24e869405184
> change-id: 20240624-tcg-bf8116e80afa
>
> Best regards,

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [PATCH 0/6] tests/tcg/aarch64: Fix inline assemblies for clang

Posted by Akihiko Odaki 5 months ago

On 2024/06/26 23:09, Alex Bennée wrote:
> Akihiko Odaki <akihiko.odaki@daynix.com> writes:
> 
>> Unlike GCC, clang checks if the operands in assembly matches with the
>> type in C. It also does not support "x" constraint for AArch64 and
>> complains about them.
> 
> When are the test cases ever built with clang? Is this for Arm on Arm
> testing only?

I ran test QEMU built with clang on Asahi Linux.