1. Patchew
  2. QEMU
  3. View series

[PATCH] .travis.yml: Install python3-tomli in all build jobs

Thomas Huth posted 1 patch 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240624094807.182313-1-thuth@redhat.com
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>
.travis.yml | 6 ++++++
1 file changed, 6 insertions(+)
[PATCH] .travis.yml: Install python3-tomli in all build jobs
Posted by Thomas Huth 5 months ago 
Since commit 1f97715c83 ('Revert "python: use vendored tomli"')
this package is a hard requirement for compiling QEMU, so install
it now in all Travis jobs, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .travis.yml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index cef0308952..8fc1ae0cf2 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -106,6 +106,7 @@ jobs:
           - libvdeplug-dev
           - libvte-2.91-dev
           - ninja-build
+          - python3-tomli
           # Tests dependencies
           - genisoimage
       env:
@@ -141,6 +142,7 @@ jobs:
           - libvdeplug-dev
           - libvte-2.91-dev
           - ninja-build
+          - python3-tomli
           # Tests dependencies
           - genisoimage
       env:
@@ -175,6 +177,7 @@ jobs:
           - libvdeplug-dev
           - libvte-2.91-dev
           - ninja-build
+          - python3-tomli
           # Tests dependencies
           - genisoimage
       env:
@@ -215,6 +218,7 @@ jobs:
           - libzstd-dev
           - nettle-dev
           - ninja-build
+          - python3-tomli
           # Tests dependencies
           - genisoimage
       env:
@@ -231,6 +235,7 @@ jobs:
           - ninja-build
           - flex
           - bison
+          - python3-tomli
       env:
         - TEST_CMD="make check check-tcg V=1"
         - CONFIG="--disable-containers --disable-system"
@@ -263,6 +268,7 @@ jobs:
           - libvdeplug-dev
           - libvte-2.91-dev
           - ninja-build
+          - python3-tomli
       env:
         - TEST_CMD="make check-unit"
         - CONFIG="--disable-containers --disable-tcg --enable-kvm --disable-tools
-- 
2.45.2
Re: [PATCH] .travis.yml: Install python3-tomli in all build jobs
Posted by Alex Bennée 5 months ago 
Thomas Huth <thuth@redhat.com> writes:

> Since commit 1f97715c83 ('Revert "python: use vendored tomli"')
> this package is a hard requirement for compiling QEMU, so install
> it now in all Travis jobs, too.

AFAICT the only repo currently running these tests is your github
mirror:

  https://app.travis-ci.com/github/huth/qemu/builds?serverType=git

Because both the official github mirror and the gitlab project haven't
run anything for a while:

  https://app.travis-ci.com/gitlab/qemu-project/qemu/branches
  https://app.travis-ci.com/github/qemu/qemu/branches

I've never been able to get anything to build since they transitioned to
TravisCI.com

>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  .travis.yml | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/.travis.yml b/.travis.yml
> index cef0308952..8fc1ae0cf2 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -106,6 +106,7 @@ jobs:
>            - libvdeplug-dev
>            - libvte-2.91-dev
>            - ninja-build
> +          - python3-tomli
>            # Tests dependencies
>            - genisoimage
>        env:
> @@ -141,6 +142,7 @@ jobs:
>            - libvdeplug-dev
>            - libvte-2.91-dev
>            - ninja-build
> +          - python3-tomli
>            # Tests dependencies
>            - genisoimage
>        env:
> @@ -175,6 +177,7 @@ jobs:
>            - libvdeplug-dev
>            - libvte-2.91-dev
>            - ninja-build
> +          - python3-tomli
>            # Tests dependencies
>            - genisoimage
>        env:
> @@ -215,6 +218,7 @@ jobs:
>            - libzstd-dev
>            - nettle-dev
>            - ninja-build
> +          - python3-tomli
>            # Tests dependencies
>            - genisoimage
>        env:
> @@ -231,6 +235,7 @@ jobs:
>            - ninja-build
>            - flex
>            - bison
> +          - python3-tomli
>        env:
>          - TEST_CMD="make check check-tcg V=1"
>          - CONFIG="--disable-containers --disable-system"
> @@ -263,6 +268,7 @@ jobs:
>            - libvdeplug-dev
>            - libvte-2.91-dev
>            - ninja-build
> +          - python3-tomli
>        env:
>          - TEST_CMD="make check-unit"
>          - CONFIG="--disable-containers --disable-tcg --enable-kvm --disable-tools

FWIW the changes themselves look fine:

Acked-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro
Re: [PATCH] .travis.yml: Install python3-tomli in all build jobs
Posted by Thomas Huth 5 months ago 
On 24/06/2024 12.09, Alex Bennée wrote:
> Thomas Huth <thuth@redhat.com> writes:
> 
>> Since commit 1f97715c83 ('Revert "python: use vendored tomli"')
>> this package is a hard requirement for compiling QEMU, so install
>> it now in all Travis jobs, too.
> 
> AFAICT the only repo currently running these tests is your github
> mirror:
> 
>    https://app.travis-ci.com/github/huth/qemu/builds?serverType=git
> 
> Because both the official github mirror and the gitlab project haven't
> run anything for a while:
> 
>    https://app.travis-ci.com/gitlab/qemu-project/qemu/branches
>    https://app.travis-ci.com/github/qemu/qemu/branches

AFAIK the gitlab integration broke completely at one point in time. But as 
you can see with my account, it still works fine for the github repo - I 
just need to write a short mail to the travis support once a year to ask 
them to extend the open source credits for my repo. So apart from that minor 
effort, it's a very convenient way to test QEMU on non-x86 hosts.

> FWIW the changes themselves look fine:
> 
> Acked-by: Alex Bennée <alex.bennee@linaro.org>

Thanks!

  Thomas
Re: [PATCH] .travis.yml: Install python3-tomli in all build jobs
Posted by Stefan Weil via 3 months ago 
Am 24.06.24 um 12:31 schrieb Thomas Huth:
> On 24/06/2024 12.09, Alex Bennée wrote:
>> Thomas Huth <thuth@redhat.com> writes:
>>
>>> Since commit 1f97715c83 ('Revert "python: use vendored tomli"')
>>> this package is a hard requirement for compiling QEMU, so install
>>> it now in all Travis jobs, too.
>>
>> AFAICT the only repo currently running these tests is your github
>> mirror:
>>
>>    https://app.travis-ci.com/github/huth/qemu/builds?serverType=git
>>
>> Because both the official github mirror and the gitlab project haven't
>> run anything for a while:
>>
>>    https://app.travis-ci.com/gitlab/qemu-project/qemu/branches
>>    https://app.travis-ci.com/github/qemu/qemu/branches
> 
> AFAIK the gitlab integration broke completely at one point in time. But 
> as you can see with my account, it still works fine for the github repo 
> - I just need to write a short mail to the travis support once a year to 
> ask them to extend the open source credits for my repo. So apart from 
> that minor effort, it's a very convenient way to test QEMU on non-x86 
> hosts.


https://app.travis-ci.com/github/qemu/qemu/requests shows recent 
requests. But all requests are refused: "Owner qemu is not on a new 
pricing". So whoever is "qemu", he/she might do the same as you did and 
write to the Travis support.

And https://travis-ci.org/qemu/qemu could be replaced by 
https://app.travis-ci.com/github/qemu/qemu in MAINTAINERS.

Stefan

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.