migration: Remove unused VMSTATE_ARRAY_TEST() macro

[PATCH] migration: Remove unused VMSTATE_ARRAY_TEST() macro

Posted by Philippe Mathieu-Daudé 5 months ago

Last use of VMSTATE_ARRAY_TEST() was removed in commit 46baa9007f
("migration/i386: Remove old non-softfloat 64bit FP support"), we
can safely get rid of it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/migration/vmstate.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 294d2d8486..f313f2f408 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -388,16 +388,6 @@ extern const VMStateInfo vmstate_info_qlist;
     .offset     = vmstate_offset_varray(_state, _field, _type),      \
 }
 
-#define VMSTATE_ARRAY_TEST(_field, _state, _num, _test, _info, _type) {\
-    .name         = (stringify(_field)),                              \
-    .field_exists = (_test),                                          \
-    .num          = (_num),                                           \
-    .info         = &(_info),                                         \
-    .size         = sizeof(_type),                                    \
-    .flags        = VMS_ARRAY,                                        \
-    .offset       = vmstate_offset_array(_state, _field, _type, _num),\
-}
-
 #define VMSTATE_SUB_ARRAY(_field, _state, _start, _num, _version, _info, _type) { \
     .name       = (stringify(_field)),                               \
     .version_id = (_version),                                        \
-- 
2.41.0

Re: [PATCH] migration: Remove unused VMSTATE_ARRAY_TEST() macro

Posted by Fabiano Rosas 5 months ago

On Fri, 21 Jun 2024 09:03:17 +0200, Philippe Mathieu-Daudé wrote:
> Last use of VMSTATE_ARRAY_TEST() was removed in commit 46baa9007f
> ("migration/i386: Remove old non-softfloat 64bit FP support"), we
> can safely get rid of it.
> 
> 

Queued, thanks!

Re: [PATCH] migration: Remove unused VMSTATE_ARRAY_TEST() macro

Posted by Zhijian Li (Fujitsu) via 5 months ago


On 21/06/2024 15:03, Philippe Mathieu-Daudé wrote:
> Last use of VMSTATE_ARRAY_TEST() was removed in commit 46baa9007f
> ("migration/i386: Remove old non-softfloat 64bit FP support"), we
> can safely get rid of it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>


> ---
>   include/migration/vmstate.h | 10 ----------
>   1 file changed, 10 deletions(-)
> 
> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
> index 294d2d8486..f313f2f408 100644
> --- a/include/migration/vmstate.h
> +++ b/include/migration/vmstate.h
> @@ -388,16 +388,6 @@ extern const VMStateInfo vmstate_info_qlist;
>       .offset     = vmstate_offset_varray(_state, _field, _type),      \
>   }
>   
> -#define VMSTATE_ARRAY_TEST(_field, _state, _num, _test, _info, _type) {\
> -    .name         = (stringify(_field)),                              \
> -    .field_exists = (_test),                                          \
> -    .num          = (_num),                                           \
> -    .info         = &(_info),                                         \
> -    .size         = sizeof(_type),                                    \
> -    .flags        = VMS_ARRAY,                                        \
> -    .offset       = vmstate_offset_array(_state, _field, _type, _num),\
> -}
> -
>   #define VMSTATE_SUB_ARRAY(_field, _state, _start, _num, _version, _info, _type) { \
>       .name       = (stringify(_field)),                               \
>       .version_id = (_version),                                        \

Re: [PATCH] migration: Remove unused VMSTATE_ARRAY_TEST() macro

Posted by Peter Xu 5 months ago

On Fri, Jun 21, 2024 at 08:13:35AM +0000, Zhijian Li (Fujitsu) via wrote:
> 
> 
> On 21/06/2024 15:03, Philippe Mathieu-Daudé wrote:
> > Last use of VMSTATE_ARRAY_TEST() was removed in commit 46baa9007f
> > ("migration/i386: Remove old non-softfloat 64bit FP support"), we
> > can safely get rid of it.
> > 
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> 
> Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu