hw/core/cpu.h: try and document CPU_FOREACH[_SAFE]

[RFC PATCH] hw/core/cpu.h: try and document CPU_FOREACH[_SAFE]

Posted by Alex Bennée 5 months, 1 week ago

There is some confusion about when you should use one over the other.
Lets try and address that by adding some kdoc comments.

Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 include/hw/core/cpu.h | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
index a2c8536943..7122f742c1 100644
--- a/include/hw/core/cpu.h
+++ b/include/hw/core/cpu.h
@@ -587,8 +587,25 @@ extern CPUTailQ cpus_queue;
 
 #define first_cpu        QTAILQ_FIRST_RCU(&cpus_queue)
 #define CPU_NEXT(cpu)    QTAILQ_NEXT_RCU(cpu, node)
+
+/**
+ * CPU_FOREACH - Helper to iterate over all CPUs
+ *
+ * This macro iterates over all CPUs in the system. It must be used
+ * under an RCU read protection, e.g. WITH_RCU_READ_LOCK_GUARD(). If
+ * you don't want the CPU list to change while iterating use
+ * CPU_FOREACH_SAFE under the cpu_list_lock().
+ */
 #define CPU_FOREACH(cpu) QTAILQ_FOREACH_RCU(cpu, &cpus_queue, node)
-#define CPU_FOREACH_SAFE(cpu, next_cpu) \
+
+/**
+ * CPU_FOREACH_SAFE - Helper to iterate over all CPUs, safe against CPU changes
+ *
+ * This macro iterates over all CPUs in the system, and is safe
+ * against CPU list changes. The target data structure must be
+ * protected by cpu_list_lock(), and does not need RCU.
+ */
+#define CPU_FOREACH_SAFE(cpu, next_cpu)                         \
     QTAILQ_FOREACH_SAFE_RCU(cpu, &cpus_queue, node, next_cpu)
 
 extern __thread CPUState *current_cpu;
-- 
2.39.2

Re: [RFC PATCH] hw/core/cpu.h: try and document CPU_FOREACH[_SAFE]

Posted by Alex Bennée 4 months, 1 week ago

Alex Bennée <alex.bennee@linaro.org> writes:

> There is some confusion about when you should use one over the other.
> Lets try and address that by adding some kdoc comments.
>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

ping?

> ---
>  include/hw/core/cpu.h | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
> index a2c8536943..7122f742c1 100644
> --- a/include/hw/core/cpu.h
> +++ b/include/hw/core/cpu.h
> @@ -587,8 +587,25 @@ extern CPUTailQ cpus_queue;
>  
>  #define first_cpu        QTAILQ_FIRST_RCU(&cpus_queue)
>  #define CPU_NEXT(cpu)    QTAILQ_NEXT_RCU(cpu, node)
> +
> +/**
> + * CPU_FOREACH - Helper to iterate over all CPUs
> + *
> + * This macro iterates over all CPUs in the system. It must be used
> + * under an RCU read protection, e.g. WITH_RCU_READ_LOCK_GUARD(). If
> + * you don't want the CPU list to change while iterating use
> + * CPU_FOREACH_SAFE under the cpu_list_lock().
> + */
>  #define CPU_FOREACH(cpu) QTAILQ_FOREACH_RCU(cpu, &cpus_queue, node)
> -#define CPU_FOREACH_SAFE(cpu, next_cpu) \
> +
> +/**
> + * CPU_FOREACH_SAFE - Helper to iterate over all CPUs, safe against CPU changes
> + *
> + * This macro iterates over all CPUs in the system, and is safe
> + * against CPU list changes. The target data structure must be
> + * protected by cpu_list_lock(), and does not need RCU.
> + */
> +#define CPU_FOREACH_SAFE(cpu, next_cpu)                         \
>      QTAILQ_FOREACH_SAFE_RCU(cpu, &cpus_queue, node, next_cpu)
>  
>  extern __thread CPUState *current_cpu;

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro