hw/net:ftgmac100: support AST2700

[PATCH v1 1/2] hw/net:ftgmac100: fix coding style

Posted by Jamin Lin via 5 months, 1 week ago

Fix coding style issues from checkpatch.pl

Test command:
./scripts/checkpatch.pl --no-tree -f hw/net/ftgmac100.c

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 hw/net/ftgmac100.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/hw/net/ftgmac100.c b/hw/net/ftgmac100.c
index 74b6c3d9a7..25e4c0cd5b 100644
--- a/hw/net/ftgmac100.c
+++ b/hw/net/ftgmac100.c
@@ -238,7 +238,8 @@ typedef struct {
  */
 #define FTGMAC100_MAX_FRAME_SIZE    9220
 
-/* Limits depending on the type of the frame
+/*
+ * Limits depending on the type of the frame
  *
  *   9216 for Jumbo frames (+ 4 for VLAN)
  *   1518 for other frames (+ 4 for VLAN)
@@ -533,8 +534,10 @@ static void ftgmac100_do_tx(FTGMAC100State *s, uint32_t tx_ring,
             break;
         }
 
-        /* record transmit flags as they are valid only on the first
-         * segment */
+        /*
+         * record transmit flags as they are valid only on the first
+         * segment
+         */
         if (bd.des0 & FTGMAC100_TXDES0_FTS) {
             flags = bd.des1;
         }
@@ -639,7 +642,8 @@ static bool ftgmac100_can_receive(NetClientState *nc)
  */
 static uint32_t ftgmac100_rxpoll(FTGMAC100State *s)
 {
-    /* Polling times :
+    /*
+     * Polling times :
      *
      * Speed      TIME_SEL=0    TIME_SEL=1
      *
-- 
2.34.1

Re: [PATCH v1 1/2] hw/net:ftgmac100: fix coding style

Posted by Cédric Le Goater 4 months, 3 weeks ago

On 6/19/24 12:01 PM, Jamin Lin wrote:
> Fix coding style issues from checkpatch.pl
> 
> Test command:
> ./scripts/checkpatch.pl --no-tree -f hw/net/ftgmac100.c
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>


Applied to aspeed-next.

Thanks,

C.




> ---
>   hw/net/ftgmac100.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/net/ftgmac100.c b/hw/net/ftgmac100.c
> index 74b6c3d9a7..25e4c0cd5b 100644
> --- a/hw/net/ftgmac100.c
> +++ b/hw/net/ftgmac100.c
> @@ -238,7 +238,8 @@ typedef struct {
>    */
>   #define FTGMAC100_MAX_FRAME_SIZE    9220
>   
> -/* Limits depending on the type of the frame
> +/*
> + * Limits depending on the type of the frame
>    *
>    *   9216 for Jumbo frames (+ 4 for VLAN)
>    *   1518 for other frames (+ 4 for VLAN)
> @@ -533,8 +534,10 @@ static void ftgmac100_do_tx(FTGMAC100State *s, uint32_t tx_ring,
>               break;
>           }
>   
> -        /* record transmit flags as they are valid only on the first
> -         * segment */
> +        /*
> +         * record transmit flags as they are valid only on the first
> +         * segment
> +         */
>           if (bd.des0 & FTGMAC100_TXDES0_FTS) {
>               flags = bd.des1;
>           }
> @@ -639,7 +642,8 @@ static bool ftgmac100_can_receive(NetClientState *nc)
>    */
>   static uint32_t ftgmac100_rxpoll(FTGMAC100State *s)
>   {
> -    /* Polling times :
> +    /*
> +     * Polling times :
>        *
>        * Speed      TIME_SEL=0    TIME_SEL=1
>        *

Re: [PATCH v1 1/2] hw/net:ftgmac100: fix coding style

Posted by Cédric Le Goater 5 months, 1 week ago

On 6/19/24 12:01 PM, Jamin Lin wrote:
> Fix coding style issues from checkpatch.pl
> 
> Test command:
> ./scripts/checkpatch.pl --no-tree -f hw/net/ftgmac100.c
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/net/ftgmac100.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/net/ftgmac100.c b/hw/net/ftgmac100.c
> index 74b6c3d9a7..25e4c0cd5b 100644
> --- a/hw/net/ftgmac100.c
> +++ b/hw/net/ftgmac100.c
> @@ -238,7 +238,8 @@ typedef struct {
>    */
>   #define FTGMAC100_MAX_FRAME_SIZE    9220
>   
> -/* Limits depending on the type of the frame
> +/*
> + * Limits depending on the type of the frame
>    *
>    *   9216 for Jumbo frames (+ 4 for VLAN)
>    *   1518 for other frames (+ 4 for VLAN)
> @@ -533,8 +534,10 @@ static void ftgmac100_do_tx(FTGMAC100State *s, uint32_t tx_ring,
>               break;
>           }
>   
> -        /* record transmit flags as they are valid only on the first
> -         * segment */
> +        /*
> +         * record transmit flags as they are valid only on the first
> +         * segment
> +         */
>           if (bd.des0 & FTGMAC100_TXDES0_FTS) {
>               flags = bd.des1;
>           }
> @@ -639,7 +642,8 @@ static bool ftgmac100_can_receive(NetClientState *nc)
>    */
>   static uint32_t ftgmac100_rxpoll(FTGMAC100State *s)
>   {
> -    /* Polling times :
> +    /*
> +     * Polling times :
>        *
>        * Speed      TIME_SEL=0    TIME_SEL=1
>        *