[v1] hw/net: Fix Coverity Issue for npcm-gmac

[PATCH] hw/net: Fix Coverity Issue for npcm-gmac

Nabih Estefan posted 1 patch 5 months, 1 week ago

Diff against v1 v1 v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240618172442.3449262-2-nabihestefan@google.com

Maintainers: Tyrone Ting <kfting@nuvoton.com>, Hao Wu <wuhaotsh@google.com>, Jason Wang <jasowang@redhat.com>

There is a newer version of this series

hw/net/npcm_gmac.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[PATCH] hw/net: Fix Coverity Issue for npcm-gmac

Posted by Nabih Estefan 5 months, 1 week ago

There is an extra `buf=` set that is not used by npcm-gmac. Remove it
for coverity to be happy.

Signed-off-by: Nabih Estefan <nabihestefan@google.com>
---
 hw/net/npcm_gmac.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/net/npcm_gmac.c b/hw/net/npcm_gmac.c
index 1b71e2526e..b397fd5064 100644
--- a/hw/net/npcm_gmac.c
+++ b/hw/net/npcm_gmac.c
@@ -614,7 +614,6 @@ static void gmac_try_send_next_packet(NPCMGMACState *gmac)
             net_checksum_calculate(tx_send_buffer, length, csum);
             qemu_send_packet(qemu_get_queue(gmac->nic), tx_send_buffer, length);
             trace_npcm_gmac_packet_sent(DEVICE(gmac)->canonical_path, length);
-            buf = tx_send_buffer;
             length = 0;
         }
 
-- 
2.45.2.627.g7a2c4fd464-goog

RE: [PATCH] hw/net: Fix Coverity Issue for npcm-gmac

Posted by Zhang, Chen 5 months, 1 week ago


> -----Original Message-----
> From: qemu-devel-bounces+chen.zhang=intel.com@nongnu.org <qemu-
> devel-bounces+chen.zhang=intel.com@nongnu.org> On Behalf Of Nabih
> Estefan
> Sent: Wednesday, June 19, 2024 1:25 AM
> To: peter.maydell@linaro.org
> Cc: qemu-devel@nongnu.org; kfting@nuvoton.com; wuhaotsh@google.com;
> jasowang@redhat.org; nabihestefan@google.com
> Subject: [PATCH] hw/net: Fix Coverity Issue for npcm-gmac
> 
> There is an extra `buf=` set that is not used by npcm-gmac. Remove it for
> coverity to be happy.
> 

Looks good to me.
By the way, I see this function comments the Steps 1/2/3...
But I can't find the page 384 of datasheet, please add more details about the datasheet(versions of datasheet, URL....).

Reviewed-by: Zhang Chen <chen.zhang@intel.com>

Thanks
Chen

> Signed-off-by: Nabih Estefan <nabihestefan@google.com>
> ---
>  hw/net/npcm_gmac.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/net/npcm_gmac.c b/hw/net/npcm_gmac.c index
> 1b71e2526e..b397fd5064 100644
> --- a/hw/net/npcm_gmac.c
> +++ b/hw/net/npcm_gmac.c
> @@ -614,7 +614,6 @@ static void
> gmac_try_send_next_packet(NPCMGMACState *gmac)
>              net_checksum_calculate(tx_send_buffer, length, csum);
>              qemu_send_packet(qemu_get_queue(gmac->nic), tx_send_buffer,
> length);
>              trace_npcm_gmac_packet_sent(DEVICE(gmac)->canonical_path,
> length);
> -            buf = tx_send_buffer;
>              length = 0;
>          }
> 
> --
> 2.45.2.627.g7a2c4fd464-goog
>