[v4] qga/linux: Add new api 'guest-network-get-route'

[PATCH v4 0/1] qga/linux: Add new api 'guest-network-get-route'

Dehan Meng posted 1 patch 4 months, 1 week ago

Diff against v1 v5
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240612043547.282552-1-demeng@redhat.com

Maintainers: Michael Roth <michael.roth@amd.com>, Konstantin Kostiuk <kkostiuk@redhat.com>

There is a newer version of this series

qga/commands-posix.c | 73 ++++++++++++++++++++++++++++++++++++++++++++
qga/commands-win32.c |  6 ++++
qga/qapi-schema.json | 68 +++++++++++++++++++++++++++++++++++++++++
3 files changed, 147 insertions(+)

Expand all Fold all

[PATCH v4 0/1] qga/linux: Add new api 'guest-network-get-route'

Posted by Dehan Meng 4 months, 1 week ago

v3 -> v4
- Fix some indentation issues
- Update 'Since 8.2' to 'Since 9.1'
- Remove useless enum and adjust this change.

v2 -> v3
- Remove this declaration and make the function 'hexToIPAddress' as static.
- Define 'IFNAMSIZ' from kernel instead of a hardcode
- Remove 'GUEST_NETWORK_ROUTE_TYPE_LINUX'
- Set flags 'has_xxx' for checking if a field exists or has a value set

v1 -> v2
- Replace snprintf() to g_strdup_printf() to avoid memory problems.
- Remove the parameter 'char ipAddress[16]' in function 'char *hexToIPAddress()'.
- Add a piece of logic to skip traversing the first line of the file

Dehan Meng (1):
  qga/linux: Add new api 'guest-network-get-route'

 qga/commands-posix.c | 73 ++++++++++++++++++++++++++++++++++++++++++++
 qga/commands-win32.c |  6 ++++
 qga/qapi-schema.json | 68 +++++++++++++++++++++++++++++++++++++++++
 3 files changed, 147 insertions(+)

-- 
2.40.1

Re: [PATCH v4 0/1] qga/linux: Add new api 'guest-network-get-route'

Posted by Konstantin Kostiuk 4 months, 1 week ago

On Wed, Jun 12, 2024 at 7:36 AM Dehan Meng <demeng@redhat.com> wrote:

> v3 -> v4
> - Fix some indentation issues
> - Update 'Since 8.2' to 'Since 9.1'
> - Remove useless enum and adjust this change.
>
> v2 -> v3
> - Remove this declaration and make the function 'hexToIPAddress' as static.
> - Define 'IFNAMSIZ' from kernel instead of a hardcode
> - Remove 'GUEST_NETWORK_ROUTE_TYPE_LINUX'
> - Set flags 'has_xxx' for checking if a field exists or has a value set
>
> v1 -> v2
> - Replace snprintf() to g_strdup_printf() to avoid memory problems.
> - Remove the parameter 'char ipAddress[16]' in function 'char
> *hexToIPAddress()'.
> - Add a piece of logic to skip traversing the first line of the file
>
>
Looks like the old version was sent. There are no changes in v1 -> v2 and
v2 -> v3 in this patch.



> Dehan Meng (1):
>   qga/linux: Add new api 'guest-network-get-route'
>
>  qga/commands-posix.c | 73 ++++++++++++++++++++++++++++++++++++++++++++
>  qga/commands-win32.c |  6 ++++
>  qga/qapi-schema.json | 68 +++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 147 insertions(+)
>
> --
> 2.40.1
>
>