cxl: Get rid of unused cfmw_list

[PATCH] cxl: Get rid of unused cfmw_list

Posted by Li Zhijian via 5 months, 3 weeks ago

There is no user for this member. All '-M cxl-fmw.N' options have
been parsed and saved to CXLState.fixed_windows.

Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
---
 hw/cxl/cxl-host.c    | 1 -
 include/hw/cxl/cxl.h | 1 -
 2 files changed, 2 deletions(-)

diff --git a/hw/cxl/cxl-host.c b/hw/cxl/cxl-host.c
index c5f5fcfd64d0..926d3d3da705 100644
--- a/hw/cxl/cxl-host.c
+++ b/hw/cxl/cxl-host.c
@@ -335,7 +335,6 @@ static void machine_set_cfmw(Object *obj, Visitor *v, const char *name,
     for (it = cfmw_list; it; it = it->next) {
         cxl_fixed_memory_window_config(state, it->value, errp);
     }
-    state->cfmw_list = cfmw_list;
 }
 
 void cxl_machine_init(Object *obj, CXLState *state)
diff --git a/include/hw/cxl/cxl.h b/include/hw/cxl/cxl.h
index 75e47b686441..e3ecbef03872 100644
--- a/include/hw/cxl/cxl.h
+++ b/include/hw/cxl/cxl.h
@@ -43,7 +43,6 @@ typedef struct CXLState {
     MemoryRegion host_mr;
     unsigned int next_mr_idx;
     GList *fixed_windows;
-    CXLFixedMemoryWindowOptionsList *cfmw_list;
 } CXLState;
 
 struct CXLHost {
-- 
2.29.2

Re: [PATCH] cxl: Get rid of unused cfmw_list

Posted by Jonathan Cameron via 5 months, 3 weeks ago

On Fri, 31 May 2024 14:13:17 +0800
Li Zhijian <lizhijian@fujitsu.com> wrote:

> There is no user for this member. All '-M cxl-fmw.N' options have
> been parsed and saved to CXLState.fixed_windows.
> 
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>

Hi Li,

Applied to my tree with slight change to patch title
to hw/cxl: Get rid of unused cfmw_list

I aim to send a group of more minor changes like this for upstream
in the next week or so.

Btw, to make it easy to spot QEMU patches in patchwork so that
the kernel maintainers can ignore them - when posting to linux-cxl@vger.kernel.org
[PATCH qemu]
marking for patches is helpful.

Thanks,

Jonathan

> ---
>  hw/cxl/cxl-host.c    | 1 -
>  include/hw/cxl/cxl.h | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/hw/cxl/cxl-host.c b/hw/cxl/cxl-host.c
> index c5f5fcfd64d0..926d3d3da705 100644
> --- a/hw/cxl/cxl-host.c
> +++ b/hw/cxl/cxl-host.c
> @@ -335,7 +335,6 @@ static void machine_set_cfmw(Object *obj, Visitor *v, const char *name,
>      for (it = cfmw_list; it; it = it->next) {
>          cxl_fixed_memory_window_config(state, it->value, errp);
>      }
> -    state->cfmw_list = cfmw_list;
>  }
>  
>  void cxl_machine_init(Object *obj, CXLState *state)
> diff --git a/include/hw/cxl/cxl.h b/include/hw/cxl/cxl.h
> index 75e47b686441..e3ecbef03872 100644
> --- a/include/hw/cxl/cxl.h
> +++ b/include/hw/cxl/cxl.h
> @@ -43,7 +43,6 @@ typedef struct CXLState {
>      MemoryRegion host_mr;
>      unsigned int next_mr_idx;
>      GList *fixed_windows;
> -    CXLFixedMemoryWindowOptionsList *cfmw_list;
>  } CXLState;
>  
>  struct CXLHost {

Re: [PATCH] cxl: Get rid of unused cfmw_list

Posted by Zhijian Li (Fujitsu) via 5 months, 3 weeks ago


On 05/06/2024 20:02, Jonathan Cameron wrote:
> On Fri, 31 May 2024 14:13:17 +0800
> Li Zhijian <lizhijian@fujitsu.com> wrote:
> 
>> There is no user for this member. All '-M cxl-fmw.N' options have
>> been parsed and saved to CXLState.fixed_windows.
>>
>> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> 
> Hi Li,
> 
> Applied to my tree with slight change to patch title
> to hw/cxl: Get rid of unused cfmw_list
> 
> I aim to send a group of more minor changes like this for upstream
> in the next week or so.

Many thanks

> 
> Btw, to make it easy to spot QEMU patches in patchwork so that
> the kernel maintainers can ignore them - when posting to linux-cxl@vger.kernel.org
> [PATCH qemu]
> marking for patches is helpful.

Thanks for your reminder.

Thanks
Zhijian

> 
> Thanks,
> 
> Jonathan
> 
>> ---
>>   hw/cxl/cxl-host.c    | 1 -
>>   include/hw/cxl/cxl.h | 1 -
>>   2 files changed, 2 deletions(-)
>>
>> diff --git a/hw/cxl/cxl-host.c b/hw/cxl/cxl-host.c
>> index c5f5fcfd64d0..926d3d3da705 100644
>> --- a/hw/cxl/cxl-host.c
>> +++ b/hw/cxl/cxl-host.c
>> @@ -335,7 +335,6 @@ static void machine_set_cfmw(Object *obj, Visitor *v, const char *name,
>>       for (it = cfmw_list; it; it = it->next) {
>>           cxl_fixed_memory_window_config(state, it->value, errp);
>>       }
>> -    state->cfmw_list = cfmw_list;
>>   }
>>   
>>   void cxl_machine_init(Object *obj, CXLState *state)
>> diff --git a/include/hw/cxl/cxl.h b/include/hw/cxl/cxl.h
>> index 75e47b686441..e3ecbef03872 100644
>> --- a/include/hw/cxl/cxl.h
>> +++ b/include/hw/cxl/cxl.h
>> @@ -43,7 +43,6 @@ typedef struct CXLState {
>>       MemoryRegion host_mr;
>>       unsigned int next_mr_idx;
>>       GList *fixed_windows;
>> -    CXLFixedMemoryWindowOptionsList *cfmw_list;
>>   } CXLState;
>>   
>>   struct CXLHost {
>