[v2] add SYS_GET_CMDLINE test

[Semihosting Tests PATCH v2 0/3] add SYS_GET_CMDLINE test

Alex Bennée posted 3 patches 5 months, 4 weeks ago

Diff against v1
Download series mbox

Failed in applying to current master (apply log)

.editorconfig | 29 +++++++++++++++++++++++++++++
Makefile      | 22 +++++++++++-----------
semihosting.c |  4 ++--
semihosting.h |  2 +-
string.c      |  2 +-
usertest.c    | 33 ++++++++++++++++++++++++++++++++-
6 files changed, 76 insertions(+), 16 deletions(-)
create mode 100644 .editorconfig

Expand all Fold all

[Semihosting Tests PATCH v2 0/3] add SYS_GET_CMDLINE test

Posted by Alex Bennée 5 months, 4 weeks ago

Hi Peter,

Looking at bug #2322 I wanted to make sure SYS_GET_CMDLINE works as I
expected. While at it I needed to fix a compile error with headers
which I guess we got away with on earlier compilers.

I've added an editorconfig for good measure.

v2
  - addressed review comments

Alex Bennée (3):
  .editorconfig: add code conventions for tooling
  update includes for bare metal compiling
  add SYS_GET_CMDLINE test

 .editorconfig | 29 +++++++++++++++++++++++++++++
 Makefile      | 22 +++++++++++-----------
 semihosting.c |  4 ++--
 semihosting.h |  2 +-
 string.c      |  2 +-
 usertest.c    | 33 ++++++++++++++++++++++++++++++++-
 6 files changed, 76 insertions(+), 16 deletions(-)
 create mode 100644 .editorconfig

-- 
2.39.2

Re: [Semihosting Tests PATCH v2 0/3] add SYS_GET_CMDLINE test

Posted by Peter Maydell 5 months, 4 weeks ago

On Thu, 30 May 2024 at 12:23, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Hi Peter,
>
> Looking at bug #2322 I wanted to make sure SYS_GET_CMDLINE works as I
> expected. While at it I needed to fix a compile error with headers
> which I guess we got away with on earlier compilers.
>
> I've added an editorconfig for good measure.
>
> v2
>   - addressed review comments
>
> Alex Bennée (3):
>   .editorconfig: add code conventions for tooling
>   update includes for bare metal compiling
>   add SYS_GET_CMDLINE test

Applied to the semihosting-tests git repo, thanks.

-- PMM