[PATCH v2 1/4] MAINTAINERS: drop audio maintainership

Gerd Hoffmann posted 4 patches 6 months ago
[PATCH v2 1/4] MAINTAINERS: drop audio maintainership
Posted by Gerd Hoffmann 6 months ago
Remove myself from audio (both devices and backend) entries.
Flip status to "Orphan" for entries which have nobody else listed.

Cc: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Cc: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
Cc: Thomas Huth <huth@tuxfamily.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 MAINTAINERS | 30 ++++++++++--------------------
 1 file changed, 10 insertions(+), 20 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 448dc951c509..58e44885ce94 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1913,8 +1913,7 @@ F: include/hw/xtensa/mx_pic.h
 Devices
 -------
 Overall Audio frontends
-M: Gerd Hoffmann <kraxel@redhat.com>
-S: Odd Fixes
+S: Orphan
 F: hw/audio/
 F: include/hw/audio/
 F: tests/qtest/ac97-test.c
@@ -2389,8 +2388,8 @@ F: hw/virtio/virtio-mem-pci.c
 F: include/hw/virtio/virtio-mem.h
 
 virtio-snd
-M: Gerd Hoffmann <kraxel@redhat.com>
-R: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
+M: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
+R: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
 S: Supported
 F: hw/audio/virtio-snd.c
 F: hw/audio/virtio-snd-pci.c
@@ -2768,7 +2767,6 @@ F: include/hw/hyperv/hv-balloon.h
 Subsystems
 ----------
 Overall Audio backends
-M: Gerd Hoffmann <kraxel@redhat.com>
 M: Marc-André Lureau <marcandre.lureau@redhat.com>
 S: Odd Fixes
 F: audio/
@@ -2784,13 +2782,11 @@ X: audio/spiceaudio.c
 F: qapi/audio.json
 
 ALSA Audio backend
-M: Gerd Hoffmann <kraxel@redhat.com>
 R: Christian Schoenebeck <qemu_oss@crudebyte.com>
-S: Odd Fixes
+S: Orphan
 F: audio/alsaaudio.c
 
 Core Audio framework backend
-M: Gerd Hoffmann <kraxel@redhat.com>
 M: Philippe Mathieu-Daudé <philmd@linaro.org>
 R: Christian Schoenebeck <qemu_oss@crudebyte.com>
 R: Akihiko Odaki <akihiko.odaki@daynix.com>
@@ -2798,36 +2794,30 @@ S: Odd Fixes
 F: audio/coreaudio.c
 
 DSound Audio backend
-M: Gerd Hoffmann <kraxel@redhat.com>
-S: Odd Fixes
+S: Orphan
 F: audio/dsound*
 
 JACK Audio Connection Kit backend
-M: Gerd Hoffmann <kraxel@redhat.com>
 R: Christian Schoenebeck <qemu_oss@crudebyte.com>
-S: Odd Fixes
+S: Orphan
 F: audio/jackaudio.c
 
 Open Sound System (OSS) Audio backend
-M: Gerd Hoffmann <kraxel@redhat.com>
-S: Odd Fixes
+S: Orphan
 F: audio/ossaudio.c
 
 PulseAudio backend
-M: Gerd Hoffmann <kraxel@redhat.com>
-S: Odd Fixes
+S: Orphan
 F: audio/paaudio.c
 
 SDL Audio backend
-M: Gerd Hoffmann <kraxel@redhat.com>
-R: Thomas Huth <huth@tuxfamily.org>
+M: Thomas Huth <huth@tuxfamily.org>
 S: Odd Fixes
 F: audio/sdlaudio.c
 
 Sndio Audio backend
-M: Gerd Hoffmann <kraxel@redhat.com>
 R: Alexandre Ratchov <alex@caoua.org>
-S: Odd Fixes
+S: Orphan
 F: audio/sndioaudio.c
 
 Block layer core
-- 
2.45.1


Re: [PATCH v2 1/4] MAINTAINERS: drop audio maintainership
Posted by Manos Pitsidianakis 6 months ago
On Tue, 28 May 2024 at 11:39, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Remove myself from audio (both devices and backend) entries.
> Flip status to "Orphan" for entries which have nobody else listed.
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  MAINTAINERS | 30 ++++++++++--------------------
>  1 file changed, 10 insertions(+), 20 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 448dc951c509..58e44885ce94 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1913,8 +1913,7 @@ F: include/hw/xtensa/mx_pic.h
>  Devices
>  -------
>  Overall Audio frontends
> -M: Gerd Hoffmann <kraxel@redhat.com>
> -S: Odd Fixes
> +S: Orphan
>  F: hw/audio/
>  F: include/hw/audio/
>  F: tests/qtest/ac97-test.c
> @@ -2389,8 +2388,8 @@ F: hw/virtio/virtio-mem-pci.c
>  F: include/hw/virtio/virtio-mem.h
>
>  virtio-snd
> -M: Gerd Hoffmann <kraxel@redhat.com>
> -R: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> +M: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> +R: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
>  S: Supported
>  F: hw/audio/virtio-snd.c
>  F: hw/audio/virtio-snd-pci.c

While extra reviewers are always helpful, someone like Volker would
make sense, not someone without any contributions:

$ git log --format="%an" hw/audio/virtio-snd.c
hw/audio/virtio-snd-pci.c include/hw/audio/virtio-snd.h
docs/system/devices/virtio-snd.rst | sort -u
Manos Pitsidianakis
Michael Tokarev
Philippe Mathieu-Daudé
Richard Henderson
Stefan Hajnoczi
Volker Rümelin
Zheyu Ma

I'd suggest leaving adding reviewers here for a different patch submission.

Otherwise:

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>


> @@ -2768,7 +2767,6 @@ F: include/hw/hyperv/hv-balloon.h
>  Subsystems
>  ----------
>  Overall Audio backends
> -M: Gerd Hoffmann <kraxel@redhat.com>
>  M: Marc-André Lureau <marcandre.lureau@redhat.com>
>  S: Odd Fixes
>  F: audio/
> @@ -2784,13 +2782,11 @@ X: audio/spiceaudio.c
>  F: qapi/audio.json
>
>  ALSA Audio backend
> -M: Gerd Hoffmann <kraxel@redhat.com>
>  R: Christian Schoenebeck <qemu_oss@crudebyte.com>
> -S: Odd Fixes
> +S: Orphan
>  F: audio/alsaaudio.c
>
>  Core Audio framework backend
> -M: Gerd Hoffmann <kraxel@redhat.com>
>  M: Philippe Mathieu-Daudé <philmd@linaro.org>
>  R: Christian Schoenebeck <qemu_oss@crudebyte.com>
>  R: Akihiko Odaki <akihiko.odaki@daynix.com>
> @@ -2798,36 +2794,30 @@ S: Odd Fixes
>  F: audio/coreaudio.c
>
>  DSound Audio backend
> -M: Gerd Hoffmann <kraxel@redhat.com>
> -S: Odd Fixes
> +S: Orphan
>  F: audio/dsound*
>
>  JACK Audio Connection Kit backend
> -M: Gerd Hoffmann <kraxel@redhat.com>
>  R: Christian Schoenebeck <qemu_oss@crudebyte.com>
> -S: Odd Fixes
> +S: Orphan
>  F: audio/jackaudio.c
>
>  Open Sound System (OSS) Audio backend
> -M: Gerd Hoffmann <kraxel@redhat.com>
> -S: Odd Fixes
> +S: Orphan
>  F: audio/ossaudio.c
>
>  PulseAudio backend
> -M: Gerd Hoffmann <kraxel@redhat.com>
> -S: Odd Fixes
> +S: Orphan
>  F: audio/paaudio.c
>
>  SDL Audio backend
> -M: Gerd Hoffmann <kraxel@redhat.com>
> -R: Thomas Huth <huth@tuxfamily.org>
> +M: Thomas Huth <huth@tuxfamily.org>
>  S: Odd Fixes
>  F: audio/sdlaudio.c
>
>  Sndio Audio backend
> -M: Gerd Hoffmann <kraxel@redhat.com>
>  R: Alexandre Ratchov <alex@caoua.org>
> -S: Odd Fixes
> +S: Orphan
>  F: audio/sndioaudio.c
>
>  Block layer core
> --
> 2.45.1
>
Re: [PATCH v2 1/4] MAINTAINERS: drop audio maintainership
Posted by Gerd Hoffmann 6 months ago
  Hi,

> >  virtio-snd
> > -M: Gerd Hoffmann <kraxel@redhat.com>
> > -R: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> > +M: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> > +R: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> >  S: Supported
> >  F: hw/audio/virtio-snd.c
> >  F: hw/audio/virtio-snd-pci.c
> 
> While extra reviewers are always helpful, someone like Volker would
> make sense, not someone without any contributions:

Matias volunteered to help (via reply to v1 of the series), and for
'reviewer' role I don't see a reason to be strict.  'Maintainer' would
be a different story of course.

If Volker wants step up (I see you cc'ed him already) I happily add
him too.

take care,
  Gerd
Re: [PATCH v2 1/4] MAINTAINERS: drop audio maintainership
Posted by Volker Rümelin 6 months ago
Am 28.05.24 um 12:02 schrieb Gerd Hoffmann:
>   Hi,
>
>>>  virtio-snd
>>> -M: Gerd Hoffmann <kraxel@redhat.com>
>>> -R: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
>>> +M: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
>>> +R: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
>>>  S: Supported
>>>  F: hw/audio/virtio-snd.c
>>>  F: hw/audio/virtio-snd-pci.c
>> While extra reviewers are always helpful, someone like Volker would
>> make sense, not someone without any contributions:
> Matias volunteered to help (via reply to v1 of the series), and for
> 'reviewer' role I don't see a reason to be strict.  'Maintainer' would
> be a different story of course.
>
> If Volker wants step up (I see you cc'ed him already) I happily add
> him too.

Hi,

I'm sorry, but at the moment I can't step up as reviewer. As you
probably know, I'm doing this in my free time and the time I can
dedicate to QEMU is quite limited at the moment. I don't think the QEMU
developers need an unresponsive reviewer.

However, I continue to read the qemu-devel mailing list and will speak
up if I think something is wrong.

With best regards,
Volker