Fix s390x flic migration and add some more qtests

[RFC PATCH 0/3] Fix s390x flic migration and add some more qtests

Nicholas Piggin posted 3 patches 6 months ago

Download series mbox

Failed in applying to current master (apply log)

hw/intc/s390_flic.c          |  1 +
tests/qtest/migration-test.c | 25 ++++++++-----------------
2 files changed, 9 insertions(+), 17 deletions(-)

Expand all Fold all

[RFC PATCH 0/3] Fix s390x flic migration and add some more qtests

Posted by Nicholas Piggin 6 months ago

I don't know s390x enough to know if this is the right fix, but I
could debug the migration hangs this far at least (and the patch
fixes the condition that would previously result in a hang on the
qtest).

Also we could enable the test_ignore_shared test that seems to work
on s390x and ppc64 at least.

Thanks,
Nick

Nicholas Piggin (3):
  hw/intc/s390_flic: Migrate pending state
  tests/qtest/migration-test: enable on s390x
  tests/qtest/migration-test: Enable test_ignore_shared

 hw/intc/s390_flic.c          |  1 +
 tests/qtest/migration-test.c | 25 ++++++++-----------------
 2 files changed, 9 insertions(+), 17 deletions(-)

-- 
2.43.0

Re: [RFC PATCH 0/3] Fix s390x flic migration and add some more qtests

Posted by Thomas Huth 6 months ago

On 25/05/2024 15.12, Nicholas Piggin wrote:
> I don't know s390x enough to know if this is the right fix, but I
> could debug the migration hangs this far at least (and the patch
> fixes the condition that would previously result in a hang on the
> qtest).

I've run this now for a while, and the hang seems to be gone, indeed!
Pretty cool, thanks for digging into this!

Tested-by: Thomas Huth <thuth@redhat.com>