[PATCH v4 0/4] Fix sanitizer errors with clang 18.1.1

Akihiko Odaki posted 4 patches 6 months ago
Failed in applying to current master (apply log)
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Markus Armbruster <armbru@redhat.com>, Michael Roth <michael.roth@amd.com>, Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Laurent Vivier <lvivier@redhat.com>
docs/devel/build-system.rst         |  5 -----
meson.build                         | 17 ++---------------
include/qapi/clone-visitor.h        | 37 ++++++++++++++++++++++++-------------
include/qemu/lockable.h             | 23 +++++++++++++++++++----
qapi/qapi-clone-visitor.c           | 30 ++++--------------------------
qemu-keymap.c                       |  8 +++-----
stubs/blk-exp-close-all.c           |  2 +-
.gitlab-ci.d/buildtest-template.yml |  2 --
.gitlab-ci.d/buildtest.yml          |  2 --
gdbstub/meson.build                 |  2 --
tcg/meson.build                     |  2 --
tests/Makefile.include              |  2 +-
tests/qtest/libqos/meson.build      |  1 -
13 files changed, 54 insertions(+), 79 deletions(-)
[PATCH v4 0/4] Fix sanitizer errors with clang 18.1.1
Posted by Akihiko Odaki 6 months ago
I upgraded my Fedora Asahi Remix from 39 to 40 and found new sanitizer
errors with clang it ships so here are fixes.

The patch "meson: Drop the .fa library prefix" may have a broad impact
to the build system so please tell me if you have a concern with it.

To: Michael Tokarev <mjt@tls.msk.ru>
To: Laurent Vivier <laurent@vivier.eu>
To: Paolo Bonzini <pbonzini@redhat.com>
To: Marc-André Lureau <marcandre.lureau@redhat.com>
To: Daniel P. Berrangé <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
To: Philippe Mathieu-Daudé <philmd@linaro.org>
To: Alex Bennée <alex.bennee@linaro.org>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: Beraldo Leal <bleal@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>

Changes in v4:
- Fixed function pointer problems instead of ignoring them.
- Made references to allocations static instead of incompletely freeing
  them for qemu-keymap.
- s/prefix/suffix/ for patch "meson: Drop the .fa library suffix".
- Link to v3: https://lore.kernel.org/r/20240522-xkb-v3-0-c429de860fa1@daynix.com

Changes in v3:
- Moved changes that should belong to patch "meson: Drop the .fa library
  prefix" from patch "meson: Add -fno-sanitize=function".
- Link to v2: https://lore.kernel.org/r/20240522-xkb-v2-0-67b54fa7c98f@daynix.com

Changes in v2:
- Added more patches and converted them to a series.
- Link to v1: https://lore.kernel.org/r/20240501-xkb-v1-1-f046d8e11a2b@daynix.com

---
Akihiko Odaki (4):
      qemu-keymap: Make references to allocations static
      lockable: Do not cast function pointers
      qapi: Do not cast function pointers
      meson: Drop the .fa library suffix

 docs/devel/build-system.rst         |  5 -----
 meson.build                         | 17 ++---------------
 include/qapi/clone-visitor.h        | 37 ++++++++++++++++++++++++-------------
 include/qemu/lockable.h             | 23 +++++++++++++++++++----
 qapi/qapi-clone-visitor.c           | 30 ++++--------------------------
 qemu-keymap.c                       |  8 +++-----
 stubs/blk-exp-close-all.c           |  2 +-
 .gitlab-ci.d/buildtest-template.yml |  2 --
 .gitlab-ci.d/buildtest.yml          |  2 --
 gdbstub/meson.build                 |  2 --
 tcg/meson.build                     |  2 --
 tests/Makefile.include              |  2 +-
 tests/qtest/libqos/meson.build      |  1 -
 13 files changed, 54 insertions(+), 79 deletions(-)
---
base-commit: c25df57ae8f9fe1c72eee2dab37d76d904ac382e
change-id: 20240501-xkb-258483ccc5d8

Best regards,
-- 
Akihiko Odaki <akihiko.odaki@daynix.com>


Re: [PATCH v4 0/4] Fix sanitizer errors with clang 18.1.1
Posted by Thomas Huth 5 months, 4 weeks ago
On 24/05/2024 07.35, Akihiko Odaki wrote:
> I upgraded my Fedora Asahi Remix from 39 to 40 and found new sanitizer
> errors with clang it ships so here are fixes.
> 
> The patch "meson: Drop the .fa library prefix" may have a broad impact
> to the build system so please tell me if you have a concern with it.
> 
> To: Michael Tokarev <mjt@tls.msk.ru>
> To: Laurent Vivier <laurent@vivier.eu>
> To: Paolo Bonzini <pbonzini@redhat.com>
> To: Marc-André Lureau <marcandre.lureau@redhat.com>
> To: Daniel P. Berrangé <berrange@redhat.com>
> To: Thomas Huth <thuth@redhat.com>
> To: Philippe Mathieu-Daudé <philmd@linaro.org>
> To: Alex Bennée <alex.bennee@linaro.org>
> To: Wainer dos Santos Moschetta <wainersm@redhat.com>
> To: Beraldo Leal <bleal@redhat.com>
> To: Richard Henderson <richard.henderson@linaro.org>
> To: Laurent Vivier <lvivier@redhat.com>
> Cc: qemu-devel@nongnu.org
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> 
> Changes in v4:
> - Fixed function pointer problems instead of ignoring them.
> - Made references to allocations static instead of incompletely freeing
>    them for qemu-keymap.
> - s/prefix/suffix/ for patch "meson: Drop the .fa library suffix".
> - Link to v3: https://lore.kernel.org/r/20240522-xkb-v3-0-c429de860fa1@daynix.com
> 
> Changes in v3:
> - Moved changes that should belong to patch "meson: Drop the .fa library
>    prefix" from patch "meson: Add -fno-sanitize=function".
> - Link to v2: https://lore.kernel.org/r/20240522-xkb-v2-0-67b54fa7c98f@daynix.com
> 
> Changes in v2:
> - Added more patches and converted them to a series.
> - Link to v1: https://lore.kernel.org/r/20240501-xkb-v1-1-f046d8e11a2b@daynix.com
> 
> ---
> Akihiko Odaki (4):
>        qemu-keymap: Make references to allocations static
>        lockable: Do not cast function pointers
>        qapi: Do not cast function pointers
>        meson: Drop the .fa library suffix

FYI, I'll try to pick up patches 1 - 3 for my next pull request (updating 
the commit description of patch 3 according to Markus' suggestions).

Patch 4 does not apply cleanly anymore, so it needs a respin, but I'd also 
like to see this going through Paolo's meson tree if possible.

  Thomas