1. Patchew
  2. QEMU
  3. View series

[PATCH 0/7] s390x/ccw: Error reporting cleanups

Cédric Le Goater posted 7 patches 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240522170107.289532-1-clg@redhat.com
Maintainers: Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Thomas Huth <thuth@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Tony Krowiak <akrowiak@linux.ibm.com>, Jason Herne <jjherne@linux.ibm.com>, Alex Williamson <alex.williamson@redhat.com>, "Cédric Le Goater" <clg@redhat.com>
hw/s390x/ccw-device.h       |  2 +-
include/hw/s390x/s390-ccw.h |  2 +-
hw/s390x/ccw-device.c       |  3 ++-
hw/s390x/s390-ccw.c         | 29 +++++++++++++----------------
hw/vfio/ap.c                |  2 +-
hw/vfio/ccw.c               | 18 ++++++++----------
6 files changed, 26 insertions(+), 30 deletions(-)
[PATCH 0/7] s390x/ccw: Error reporting cleanups
Posted by Cédric Le Goater 6 months ago 
Hello,

The first patches of this series simply apply the practices described
in the Rules section of the qapi/error.h file for routines taking an
'Error **' argument. The remaining patches are a fixup in the error
path of vfio_ccw_realize() and some error reporting adjustements.

Applies on top of this vfio PR :

  https://lore.kernel.org/qemu-devel/20240522095442.195243-1-clg@redhat.com

Thanks,

C.

Cédric Le Goater (6):
  hw/s390x/ccw: Make s390_ccw_get_dev_info() return a bool
  s390x/css: Make CCWDeviceClass::realize return bool
  hw/s390x/ccw: Remove local Error variable from s390_ccw_realize()
  s390x/css: Make S390CCWDeviceClass::realize return bool
  vfio/ccw: Use the 'Error **errp' argument of vfio_ccw_realize()
  vfio/{ap,ccw}: Use warn_report_err() for IRQ notifier registration
    errors

Zhenzhong Duan (1):
  vfio/ccw: Fix the missed unrealize() call in error path

 hw/s390x/ccw-device.h       |  2 +-
 include/hw/s390x/s390-ccw.h |  2 +-
 hw/s390x/ccw-device.c       |  3 ++-
 hw/s390x/s390-ccw.c         | 29 +++++++++++++----------------
 hw/vfio/ap.c                |  2 +-
 hw/vfio/ccw.c               | 18 ++++++++----------
 6 files changed, 26 insertions(+), 30 deletions(-)

-- 
2.45.1
Re: [PATCH 0/7] s390x/ccw: Error reporting cleanups
Posted by Eric Farman 6 months ago 
On Wed, 2024-05-22 at 19:01 +0200, Cédric Le Goater wrote:
> Hello,
> 
> The first patches of this series simply apply the practices described
> in the Rules section of the qapi/error.h file for routines taking an
> 'Error **' argument. The remaining patches are a fixup in the error
> path of vfio_ccw_realize() and some error reporting adjustements.
> 
> Applies on top of this vfio PR :
> 
>  
> https://lore.kernel.org/qemu-devel/20240522095442.195243-1-clg@redhat.com
> 
> Thanks,
> 
> C.
> 
> Cédric Le Goater (6):
>   hw/s390x/ccw: Make s390_ccw_get_dev_info() return a bool
>   s390x/css: Make CCWDeviceClass::realize return bool
>   hw/s390x/ccw: Remove local Error variable from s390_ccw_realize()
>   s390x/css: Make S390CCWDeviceClass::realize return bool
>   vfio/ccw: Use the 'Error **errp' argument of vfio_ccw_realize()
>   vfio/{ap,ccw}: Use warn_report_err() for IRQ notifier registration
>     errors
> 
> Zhenzhong Duan (1):
>   vfio/ccw: Fix the missed unrealize() call in error path
> 
>  hw/s390x/ccw-device.h       |  2 +-
>  include/hw/s390x/s390-ccw.h |  2 +-
>  hw/s390x/ccw-device.c       |  3 ++-
>  hw/s390x/s390-ccw.c         | 29 +++++++++++++----------------
>  hw/vfio/ap.c                |  2 +-
>  hw/vfio/ccw.c               | 18 ++++++++----------
>  6 files changed, 26 insertions(+), 30 deletions(-)
> 

Reviewed-by: Eric Farman <farman@linux.ibm.com>
Re: [PATCH 0/7] s390x/ccw: Error reporting cleanups
Posted by Thomas Huth 6 months ago 
On 22/05/2024 19.01, Cédric Le Goater wrote:
> Hello,
> 
> The first patches of this series simply apply the practices described
> in the Rules section of the qapi/error.h file for routines taking an
> 'Error **' argument. The remaining patches are a fixup in the error
> path of vfio_ccw_realize() and some error reporting adjustements.
> 
> Applies on top of this vfio PR :
> 
>    https://lore.kernel.org/qemu-devel/20240522095442.195243-1-clg@redhat.com
> 
> Thanks,
> 
> C.
> 
> Cédric Le Goater (6):
>    hw/s390x/ccw: Make s390_ccw_get_dev_info() return a bool
>    s390x/css: Make CCWDeviceClass::realize return bool
>    hw/s390x/ccw: Remove local Error variable from s390_ccw_realize()
>    s390x/css: Make S390CCWDeviceClass::realize return bool
>    vfio/ccw: Use the 'Error **errp' argument of vfio_ccw_realize()
>    vfio/{ap,ccw}: Use warn_report_err() for IRQ notifier registration
>      errors

Series
Reviewed-by: Thomas Huth <thuth@redhat.com>
Re: [PATCH 0/7] s390x/ccw: Error reporting cleanups
Posted by Cédric Le Goater 6 months ago 
On 5/27/24 08:23, Thomas Huth wrote:
> On 22/05/2024 19.01, Cédric Le Goater wrote:
>> Hello,
>>
>> The first patches of this series simply apply the practices described
>> in the Rules section of the qapi/error.h file for routines taking an
>> 'Error **' argument. The remaining patches are a fixup in the error
>> path of vfio_ccw_realize() and some error reporting adjustements.
>>
>> Applies on top of this vfio PR :
>>
>>    https://lore.kernel.org/qemu-devel/20240522095442.195243-1-clg@redhat.com
>>
>> Thanks,
>>
>> C.
>>
>> Cédric Le Goater (6):
>>    hw/s390x/ccw: Make s390_ccw_get_dev_info() return a bool
>>    s390x/css: Make CCWDeviceClass::realize return bool
>>    hw/s390x/ccw: Remove local Error variable from s390_ccw_realize()
>>    s390x/css: Make S390CCWDeviceClass::realize return bool
>>    vfio/ccw: Use the 'Error **errp' argument of vfio_ccw_realize()
>>    vfio/{ap,ccw}: Use warn_report_err() for IRQ notifier registration
>>      errors
> 
> Series
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 


Applied to vfio-next.

Thanks,

C.

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.