[v3] target/hexagon: Minor idef-parser cleanup

[PATCH v3 0/4] target/hexagon: Minor idef-parser cleanup

Anton Johansson via posted 4 patches 6 months, 1 week ago

Diff against v1 v2 v4
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240521201654.25851-1-anjo@rev.ng

Maintainers: Alessandro Di Federico <ale@rev.ng>, Anton Johansson <anjo@rev.ng>

There is a newer version of this series

target/hexagon/idef-parser/idef-parser.h    | 10 ------
target/hexagon/idef-parser/idef-parser.y    |  2 --
target/hexagon/idef-parser/parser-helpers.c | 35 +++++++++++++--------
target/hexagon/idef-parser/parser-helpers.h | 13 --------
4 files changed, 22 insertions(+), 38 deletions(-)

Expand all Fold all

[PATCH v3 0/4] target/hexagon: Minor idef-parser cleanup

Posted by Anton Johansson via 6 months, 1 week ago

Was running idef-parser with valgrind and noticed we were leaking the
init_list GArray, which is used to hold instruction arguments that may
need initialization.  This patchset fixes the leak, removes unused
macros and undefined functions, and simplifies gen_inst_init_args() to
only handle predicate values.

Changes in v2:
  * Update comment in 3rd patch
  * Follow style guide in 4th patch

Changes in v3:
  * Add reviewed-bys

Anton Johansson (4):
  target/hexagon: idef-parser remove unused defines
  target/hexagon: idef-parser remove undefined functions
  target/hexagon: idef-parser fix leak of init_list
  target/hexagon: idef-parser simplify predicate init

 target/hexagon/idef-parser/idef-parser.h    | 10 ------
 target/hexagon/idef-parser/idef-parser.y    |  2 --
 target/hexagon/idef-parser/parser-helpers.c | 35 +++++++++++++--------
 target/hexagon/idef-parser/parser-helpers.h | 13 --------
 4 files changed, 22 insertions(+), 38 deletions(-)

-- 
2.45.0