qapi/qapi-schema: Clarify the dependency relationship

[PATCH 0/2] qapi/qapi-schema: Clarify the dependency relationship

Zhao Liu posted 2 patches 6 months, 1 week ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240517062748.782366-1-zhao1.liu@intel.com

Maintainers: Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>

qapi/qapi-schema.json | 100 +++++++++++++++++++++++++++++-------------
1 file changed, 69 insertions(+), 31 deletions(-)

Expand all Fold all

[PATCH 0/2] qapi/qapi-schema: Clarify the dependency relationship

Posted by Zhao Liu 6 months, 1 week ago

Hi,

At present, the correctness of the dependencies of JSON files is ensured
by the order in which they are listed, but in general, the mixing of
multiple files and the lack of clear guidelines for ordering them is not
friendly to extending and maintaining.

Therefore, I have a proposal to manually categorize and sort JSON files
generation order by dependencies/dependency hierarchy, to improve the
readability and maintainability of qapi-schema.json.

Welcome your feedback!

Thanks and Best Regards,
Zhao
---
Zhao Liu (2):
  qapi: Reorder and categorize json files in qapi-schema.json
  qapi: List block-core.json in qapi-schema.json

 qapi/qapi-schema.json | 100 +++++++++++++++++++++++++++++-------------
 1 file changed, 69 insertions(+), 31 deletions(-)

-- 
2.34.1

Re: [PATCH 0/2] qapi/qapi-schema: Clarify the dependency relationship

Posted by Zhao Liu 5 months, 4 weeks ago

Hi Eric and Markus,

Just a gentle poke. What do you think of this ordering?

Thanks,
Zhao

On Fri, May 17, 2024 at 02:27:46PM +0800, Zhao Liu wrote:
> Date: Fri, 17 May 2024 14:27:46 +0800
> From: Zhao Liu <zhao1.liu@intel.com>
> Subject: [PATCH 0/2] qapi/qapi-schema: Clarify the dependency relationship
> X-Mailer: git-send-email 2.34.1
> 
> Hi,
> 
> At present, the correctness of the dependencies of JSON files is ensured
> by the order in which they are listed, but in general, the mixing of
> multiple files and the lack of clear guidelines for ordering them is not
> friendly to extending and maintaining.
> 
> Therefore, I have a proposal to manually categorize and sort JSON files
> generation order by dependencies/dependency hierarchy, to improve the
> readability and maintainability of qapi-schema.json.
> 
> Welcome your feedback!
> 
> Thanks and Best Regards,
> Zhao
> ---
> Zhao Liu (2):
>   qapi: Reorder and categorize json files in qapi-schema.json
>   qapi: List block-core.json in qapi-schema.json
> 
>  qapi/qapi-schema.json | 100 +++++++++++++++++++++++++++++-------------
>  1 file changed, 69 insertions(+), 31 deletions(-)
> 
> -- 
> 2.34.1
>