1. Patchew
  2. QEMU
  3. [PATCH 0/7] Remove some unused structures
  4. View patch

[PATCH 6/7] target/ppc: Remove unused struct 'mmu_ctx_hash32'

Dr. David Alan Gilbert posted 7 patches 1 year, 9 months ago
Maintainers: Peter Maydell <peter.maydell@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Gerd Hoffmann <kraxel@redhat.com>, Laurent Vivier <laurent@vivier.eu>, Pavel Pisa <pisa@cmp.felk.cvut.cz>, Vikram Garhwal <fnu.vikram@xilinx.com>, Jason Wang <jasowang@redhat.com>, Nicholas Piggin <npiggin@gmail.com>, Daniel Henrique Barboza <danielhb413@gmail.com>
[PATCH 6/7] target/ppc: Remove unused struct 'mmu_ctx_hash32'
Posted by Dr. David Alan Gilbert 1 year, 9 months ago 
I think it's use was removed by
Commit 5883d8b296 ("mmu-hash*: Don't use full ppc_hash{32,
64}_translate() path for get_phys_page_debug()")

Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
---
 target/ppc/mmu-hash32.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c
index 3976416840..746321329c 100644
--- a/target/ppc/mmu-hash32.c
+++ b/target/ppc/mmu-hash32.c
@@ -36,12 +36,6 @@
 #  define LOG_BATS(...) do { } while (0)
 #endif
 
-struct mmu_ctx_hash32 {
-    hwaddr raddr;      /* Real address              */
-    int prot;                      /* Protection bits           */
-    int key;                       /* Access key                */
-};
-
 static int ppc_hash32_pp_prot(int key, int pp, int nx)
 {
     int prot;
-- 
2.45.0
Re: [PATCH 6/7] target/ppc: Remove unused struct 'mmu_ctx_hash32'
Posted by BALATON Zoltan 1 year, 9 months ago 
On Sun, 5 May 2024, Dr. David Alan Gilbert wrote:
> I think it's use was removed by
> Commit 5883d8b296 ("mmu-hash*: Don't use full ppc_hash{32,
> 64}_translate() path for get_phys_page_debug()")
>
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>

Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>

> ---
> target/ppc/mmu-hash32.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c
> index 3976416840..746321329c 100644
> --- a/target/ppc/mmu-hash32.c
> +++ b/target/ppc/mmu-hash32.c
> @@ -36,12 +36,6 @@
> #  define LOG_BATS(...) do { } while (0)
> #endif
>
> -struct mmu_ctx_hash32 {
> -    hwaddr raddr;      /* Real address              */
> -    int prot;                      /* Protection bits           */
> -    int key;                       /* Access key                */
> -};
> -
> static int ppc_hash32_pp_prot(int key, int pp, int nx)
> {
>     int prot;
>
Re: [PATCH 6/7] target/ppc: Remove unused struct 'mmu_ctx_hash32'
Posted by BALATON Zoltan 1 year, 9 months ago 
On Sun, 5 May 2024, BALATON Zoltan wrote:
> On Sun, 5 May 2024, Dr. David Alan Gilbert wrote:
>> I think it's use was removed by
>> Commit 5883d8b296 ("mmu-hash*: Don't use full ppc_hash{32,
>> 64}_translate() path for get_phys_page_debug()")
>> 
>> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
>
> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>

I've picked this patch up and will send with my series that changes the 
same place to avoid needing to rebase.

Regards,
BALATON Zoltan

>> ---
>> target/ppc/mmu-hash32.c | 6 ------
>> 1 file changed, 6 deletions(-)
>> 
>> diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c
>> index 3976416840..746321329c 100644
>> --- a/target/ppc/mmu-hash32.c
>> +++ b/target/ppc/mmu-hash32.c
>> @@ -36,12 +36,6 @@
>> #  define LOG_BATS(...) do { } while (0)
>> #endif
>> 
>> -struct mmu_ctx_hash32 {
>> -    hwaddr raddr;      /* Real address              */
>> -    int prot;                      /* Protection bits           */
>> -    int key;                       /* Access key                */
>> -};
>> -
>> static int ppc_hash32_pp_prot(int key, int pp, int nx)
>> {
>>     int prot;
>> 
>
>
Re: [PATCH 6/7] target/ppc: Remove unused struct 'mmu_ctx_hash32'
Posted by Dr. David Alan Gilbert 1 year, 9 months ago 
* BALATON Zoltan (balaton@eik.bme.hu) wrote:
> On Sun, 5 May 2024, BALATON Zoltan wrote:
> > On Sun, 5 May 2024, Dr. David Alan Gilbert wrote:
> > > I think it's use was removed by
> > > Commit 5883d8b296 ("mmu-hash*: Don't use full ppc_hash{32,
> > > 64}_translate() path for get_phys_page_debug()")
> > > 
> > > Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> > 
> > Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
> 
> I've picked this patch up and will send with my series that changes the same
> place to avoid needing to rebase.

Thanks!

Dave

> Regards,
> BALATON Zoltan
> 
> > > ---
> > > target/ppc/mmu-hash32.c | 6 ------
> > > 1 file changed, 6 deletions(-)
> > > 
> > > diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c
> > > index 3976416840..746321329c 100644
> > > --- a/target/ppc/mmu-hash32.c
> > > +++ b/target/ppc/mmu-hash32.c
> > > @@ -36,12 +36,6 @@
> > > #  define LOG_BATS(...) do { } while (0)
> > > #endif
> > > 
> > > -struct mmu_ctx_hash32 {
> > > -    hwaddr raddr;      /* Real address              */
> > > -    int prot;                      /* Protection bits           */
> > > -    int key;                       /* Access key                */
> > > -};
> > > -
> > > static int ppc_hash32_pp_prot(int key, int pp, int nx)
> > > {
> > >     int prot;
> > > 
> > 
> > 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.