1. Patchew
  2. QEMU
  3. [PULL 00/13] Migration patches for 2024-05-02
  4. View patch

[PULL 13/13] hmp/migration: Fix documents for "migrate" command

Fabiano Rosas posted 13 patches 1 year, 9 months ago
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>, Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>, "Dr. David Alan Gilbert" <dave@treblig.org>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Yanan Wang <wangyanan55@huawei.com>, Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Hailiang Zhang <zhanghailiang@xfusion.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Laurent Vivier <lvivier@redhat.com>
[PULL 13/13] hmp/migration: Fix documents for "migrate" command
Posted by Fabiano Rosas 1 year, 9 months ago 
From: Peter Xu <peterx@redhat.com>

Peter missed the Sphinx HMP document for the "resume/-r" flag in commit
7a4da28b26 ("qmp: hmp: add migrate "resume" option").  Add it.  Avoid
adding a Fixes to make life easier for the stable maintainer.

When at it, slightly cleanup the lines, move "detach/-d" to a separate
section rather than appending it at the end of the command description.

Cc: Dr. David Alan Gilbert <dave@treblig.org>
Cc: Fabiano Rosas <farosas@suse.de>
Cc: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
 hmp-commands.hx | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/hmp-commands.hx b/hmp-commands.hx
index ebca2cdced..484a8a1c3a 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -918,8 +918,13 @@ ERST
 
 
 SRST
-``migrate [-d]`` *uri*
-  Migrate to *uri* (using -d to not wait for completion).
+``migrate [-d] [-r]`` *uri*
+  Migrate the current VM to *uri*.
+
+  ``-d``
+    Run this command asynchronously, so that the command doesn't wait for completion.
+  ``-r``
+    Resume a paused postcopy migration.
 ERST
 
     {
-- 
2.35.3
Re: [PULL 13/13] hmp/migration: Fix documents for "migrate" command
Posted by Markus Armbruster 1 year, 9 months ago 
Fabiano Rosas <farosas@suse.de> writes:

> From: Peter Xu <peterx@redhat.com>
>
> Peter missed the Sphinx HMP document for the "resume/-r" flag in commit
> 7a4da28b26 ("qmp: hmp: add migrate "resume" option").  Add it.  Avoid
> adding a Fixes to make life easier for the stable maintainer.
>
> When at it, slightly cleanup the lines, move "detach/-d" to a separate
> section rather than appending it at the end of the command description.
>
> Cc: Dr. David Alan Gilbert <dave@treblig.org>
> Cc: Fabiano Rosas <farosas@suse.de>
> Cc: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> Reviewed-by: Fabiano Rosas <farosas@suse.de>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>  hmp-commands.hx | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index ebca2cdced..484a8a1c3a 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -918,8 +918,13 @@ ERST
>  
>  
>  SRST
> -``migrate [-d]`` *uri*
> -  Migrate to *uri* (using -d to not wait for completion).
> +``migrate [-d] [-r]`` *uri*
> +  Migrate the current VM to *uri*.
> +
> +  ``-d``
> +    Run this command asynchronously, so that the command doesn't wait for completion.
> +  ``-r``
> +    Resume a paused postcopy migration.
>  ERST
>  
>      {

I have questions on this one.
Re: [PULL 13/13] hmp/migration: Fix documents for "migrate" command
Posted by Fabiano Rosas 1 year, 9 months ago 
Markus Armbruster <armbru@redhat.com> writes:

> Fabiano Rosas <farosas@suse.de> writes:
>
>> From: Peter Xu <peterx@redhat.com>
>>
>> Peter missed the Sphinx HMP document for the "resume/-r" flag in commit
>> 7a4da28b26 ("qmp: hmp: add migrate "resume" option").  Add it.  Avoid
>> adding a Fixes to make life easier for the stable maintainer.
>>
>> When at it, slightly cleanup the lines, move "detach/-d" to a separate
>> section rather than appending it at the end of the command description.
>>
>> Cc: Dr. David Alan Gilbert <dave@treblig.org>
>> Cc: Fabiano Rosas <farosas@suse.de>
>> Cc: Markus Armbruster <armbru@redhat.com>
>> Signed-off-by: Peter Xu <peterx@redhat.com>
>> Reviewed-by: Fabiano Rosas <farosas@suse.de>
>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>> ---
>>  hmp-commands.hx | 9 +++++++--
>>  1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>> index ebca2cdced..484a8a1c3a 100644
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -918,8 +918,13 @@ ERST
>>  
>>  
>>  SRST
>> -``migrate [-d]`` *uri*
>> -  Migrate to *uri* (using -d to not wait for completion).
>> +``migrate [-d] [-r]`` *uri*
>> +  Migrate the current VM to *uri*.
>> +
>> +  ``-d``
>> +    Run this command asynchronously, so that the command doesn't wait for completion.
>> +  ``-r``
>> +    Resume a paused postcopy migration.
>>  ERST
>>  
>>      {
>
> I have questions on this one.

Yep, I should have waited longer before queuing this one, my bad.
Re: [PULL 13/13] hmp/migration: Fix documents for "migrate" command
Posted by Richard Henderson 1 year, 9 months ago 
On 5/3/24 05:51, Fabiano Rosas wrote:
> Markus Armbruster <armbru@redhat.com> writes:
> 
>> Fabiano Rosas <farosas@suse.de> writes:
>>
>>> From: Peter Xu <peterx@redhat.com>
>>>
>>> Peter missed the Sphinx HMP document for the "resume/-r" flag in commit
>>> 7a4da28b26 ("qmp: hmp: add migrate "resume" option").  Add it.  Avoid
>>> adding a Fixes to make life easier for the stable maintainer.
>>>
>>> When at it, slightly cleanup the lines, move "detach/-d" to a separate
>>> section rather than appending it at the end of the command description.
>>>
>>> Cc: Dr. David Alan Gilbert <dave@treblig.org>
>>> Cc: Fabiano Rosas <farosas@suse.de>
>>> Cc: Markus Armbruster <armbru@redhat.com>
>>> Signed-off-by: Peter Xu <peterx@redhat.com>
>>> Reviewed-by: Fabiano Rosas <farosas@suse.de>
>>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>>> ---
>>>   hmp-commands.hx | 9 +++++++--
>>>   1 file changed, 7 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>>> index ebca2cdced..484a8a1c3a 100644
>>> --- a/hmp-commands.hx
>>> +++ b/hmp-commands.hx
>>> @@ -918,8 +918,13 @@ ERST
>>>   
>>>   
>>>   SRST
>>> -``migrate [-d]`` *uri*
>>> -  Migrate to *uri* (using -d to not wait for completion).
>>> +``migrate [-d] [-r]`` *uri*
>>> +  Migrate the current VM to *uri*.
>>> +
>>> +  ``-d``
>>> +    Run this command asynchronously, so that the command doesn't wait for completion.
>>> +  ``-r``
>>> +    Resume a paused postcopy migration.
>>>   ERST
>>>   
>>>       {
>>
>> I have questions on this one.
> 
> Yep, I should have waited longer before queuing this one, my bad.

Ok, I will not process this pull request.


r~

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.