qtest/migration: Fixes around multifd_tcp_channels_none migration qtest

[PATCH v2 0/3] qtest/migration: Fixes around multifd_tcp_channels_none migration qtest

Posted by Het Gala 3 weeks, 2 days ago

With the introduction of new patchset to have 'channels' as the start
argument of migrate QAPIs instead of 'uri' (tests/qtest/migration: Add
tests for introducing 'channels' argument in migrate QAPIs), a few minor
issues got went unnoticed, which were caught while trying to introduce
similar qtests in migration-test.c
Fix multifd_tcp_channels_none qtest to actually utilize 'channels' arg
in migrate QAPIs, fix double freeing of addr Qdict and typos in that
patchset.

This patchset is built on top of (tests/qtest/migration: Add tests for
introducing 'channels' argument in migrate QAPIs) 

Can find the build pipeline at : https://gitlab.com/galahet/Qemu/-/pipelines/1245462266

v1 --> v2:
---------
1. Split the second patch into different patches - One to deal with double
   freeing of Qdict and other to add connect_channels inside
   multifd_tcp_channels_none to actually use 'channels' arg.
2. use 'git commit --fixup' to improve commit message as well as
   to inform on which commit is the fix meant to be.

Het Gala (3):
  fixup! tests/qtest/migration: Add negative tests to validate migration
    QAPIs
  fixup! tests/qtest/migration: Add migrate_set_ports into migrate_qmp
    to update migration port value
  fixup! tests/qtest/migration: Add multifd_tcp_plain test using list of
    channels instead of uri

 tests/qtest/migration-helpers.c | 4 ++--
 tests/qtest/migration-test.c    | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.22.3

Re: [PATCH v2 0/3] qtest/migration: Fixes around multifd_tcp_channels_none migration qtest

Posted by Peter Xu 3 weeks, 2 days ago

On Tue, Apr 09, 2024 at 11:00:08AM +0000, Het Gala wrote:
> With the introduction of new patchset to have 'channels' as the start
> argument of migrate QAPIs instead of 'uri' (tests/qtest/migration: Add
> tests for introducing 'channels' argument in migrate QAPIs), a few minor
> issues got went unnoticed, which were caught while trying to introduce
> similar qtests in migration-test.c
> Fix multifd_tcp_channels_none qtest to actually utilize 'channels' arg
> in migrate QAPIs, fix double freeing of addr Qdict and typos in that
> patchset.
> 
> This patchset is built on top of (tests/qtest/migration: Add tests for
> introducing 'channels' argument in migrate QAPIs) 
> 
> Can find the build pipeline at : https://gitlab.com/galahet/Qemu/-/pipelines/1245462266
> 
> v1 --> v2:
> ---------
> 1. Split the second patch into different patches - One to deal with double
>    freeing of Qdict and other to add connect_channels inside
>    multifd_tcp_channels_none to actually use 'channels' arg.
> 2. use 'git commit --fixup' to improve commit message as well as
>    to inform on which commit is the fix meant to be.
> 
> Het Gala (3):
>   fixup! tests/qtest/migration: Add negative tests to validate migration
>     QAPIs
>   fixup! tests/qtest/migration: Add migrate_set_ports into migrate_qmp
>     to update migration port value
>   fixup! tests/qtest/migration: Add multifd_tcp_plain test using list of
>     channels instead of uri

queued, thanks.

-- 
Peter Xu