[v1] scripts/checkpatch: Do not use mailmap and check qemu-trivial@ author

[PATCH 1/2] scripts/checkpatch: Avoid author email mangled by qemu-trivial@

Posted by Philippe Mathieu-Daudé 1 year, 10 months ago

Commit f5177798d8 ("scripts: report on author emails
that are mangled by the mailing list") added a check
for qemu-devel@ list, complete with qemu-trivial@.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 7026895074..4fe4cfd631 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1573,7 +1573,7 @@ sub process {
 			$is_patch = 1;
 		}
 
-		if ($line =~ /^(Author|From): .* via .*<qemu-devel\@nongnu.org>/) {
+		if ($line =~ /^(Author|From): .* via .*<qemu-(devel|trivial)\@nongnu\.org>/) {
 		    ERROR("Author email address is mangled by the mailing list\n" . $herecurr);
 		}
 
-- 
2.41.0

Re: [PATCH 1/2] scripts/checkpatch: Avoid author email mangled by qemu-trivial@

Posted by Peter Maydell 1 year, 10 months ago

On Tue, 2 Apr 2024 at 12:30, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Commit f5177798d8 ("scripts: report on author emails
> that are mangled by the mailing list") added a check
> for qemu-devel@ list, complete with qemu-trivial@.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 7026895074..4fe4cfd631 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1573,7 +1573,7 @@ sub process {
>                         $is_patch = 1;
>                 }
>
> -               if ($line =~ /^(Author|From): .* via .*<qemu-devel\@nongnu.org>/) {
> +               if ($line =~ /^(Author|From): .* via .*<qemu-(devel|trivial)\@nongnu\.org>/) {

I recommend checking against qemu-.* rather than trying
to capture explicitly all the suffixes we have. (For instance
there's a line in mailmap for a commit that was attributed
to qemu-block@, which this change still wouldn't catch.)

thanks
-- PMM

Re: [PATCH 1/2] scripts/checkpatch: Avoid author email mangled by qemu-trivial@

Posted by Philippe Mathieu-Daudé 1 year, 10 months ago

On 2/4/24 13:52, Peter Maydell wrote:
> On Tue, 2 Apr 2024 at 12:30, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>>
>> Commit f5177798d8 ("scripts: report on author emails
>> that are mangled by the mailing list") added a check
>> for qemu-devel@ list, complete with qemu-trivial@.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>>   scripts/checkpatch.pl | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index 7026895074..4fe4cfd631 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -1573,7 +1573,7 @@ sub process {
>>                          $is_patch = 1;
>>                  }
>>
>> -               if ($line =~ /^(Author|From): .* via .*<qemu-devel\@nongnu.org>/) {
>> +               if ($line =~ /^(Author|From): .* via .*<qemu-(devel|trivial)\@nongnu\.org>/) {
> 
> I recommend checking against qemu-.* rather than trying
> to capture explicitly all the suffixes we have. (For instance
> there's a line in mailmap for a commit that was attributed
> to qemu-block@, which this change still wouldn't catch.)

Oh, good point.

Re: [PATCH 1/2] scripts/checkpatch: Avoid author email mangled by qemu-trivial@

Posted by Philippe Mathieu-Daudé 1 year, 10 months ago

On 2/4/24 13:53, Philippe Mathieu-Daudé wrote:
> On 2/4/24 13:52, Peter Maydell wrote:
>> On Tue, 2 Apr 2024 at 12:30, Philippe Mathieu-Daudé 
>> <philmd@linaro.org> wrote:
>>>
>>> Commit f5177798d8 ("scripts: report on author emails
>>> that are mangled by the mailing list") added a check
>>> for qemu-devel@ list, complete with qemu-trivial@.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> ---
>>>   scripts/checkpatch.pl | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>>> index 7026895074..4fe4cfd631 100755
>>> --- a/scripts/checkpatch.pl
>>> +++ b/scripts/checkpatch.pl
>>> @@ -1573,7 +1573,7 @@ sub process {
>>>                          $is_patch = 1;
>>>                  }
>>>
>>> -               if ($line =~ /^(Author|From): .* via 
>>> .*<qemu-devel\@nongnu.org>/) {
>>> +               if ($line =~ /^(Author|From): .* via 
>>> .*<qemu-(devel|trivial)\@nongnu\.org>/) {
>>
>> I recommend checking against qemu-.* rather than trying
>> to capture explicitly all the suffixes we have. (For instance
>> there's a line in mailmap for a commit that was attributed
>> to qemu-block@, which this change still wouldn't catch.)
> 
> Oh, good point.

And also qemu-ppc@nongnu.org:

commit 5cbd51a5a58098444ffa246ece2013849be04299
Author: BALATON Zoltan via <qemu-ppc@nongnu.org>
Date:   Sun Jan 3 02:09:33 2021 +0100