[v2] machine development tool

[PULL v2 0/4] machine development tool

Maksim Davydov posted 4 patches 1 month, 1 week ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240318213550.155573-1-davydov-max@yandex-team.ru

Maintainers: Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>, John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, Beraldo Leal <bleal@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Maksim Davydov <davydov-max@yandex-team.ru>, Alexander Bulekov <alxndr@bu.edu>, Bandan Das <bsd@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Thomas Huth <thuth@redhat.com>, Darren Kenny <darren.kenny@oracle.com>, Qiuhao Li <Qiuhao.Li@outlook.com>, Laurent Vivier <lvivier@redhat.com>

MAINTAINERS                      |   5 +
hw/core/machine-qmp-cmds.c       |  23 +-
python/qemu/machine/machine.py   |   5 +
qapi/machine.json                |  67 ++++-
qom/qom-qmp-cmds.c               |   1 +
scripts/compare-machine-types.py | 486 +++++++++++++++++++++++++++++++
tests/qtest/fuzz/qos_fuzz.c      |   2 +-
7 files changed, 585 insertions(+), 4 deletions(-)
create mode 100755 scripts/compare-machine-types.py

Expand all Fold all

[PULL v2 0/4] machine development tool

Posted by Maksim Davydov 1 month, 1 week ago

The following changes since commit ba49d760eb04630e7b15f423ebecf6c871b8f77b:

  Merge tag 'pull-maintainer-final-130324-1' of https://gitlab.com/stsquad/qemu into staging (2024-03-13 15:12:14 +0000)

are available in the Git repository at:

  https://gitlab.com/davydov-max/qemu.git tags/pull-compare-mt-2024-03-19

for you to fetch changes up to e12b89f71ba5b93877b6a3adc379a6369d0c9bab:

  scripts: add script to compare compatibility properties (2024-03-19 00:13:54 +0300)

----------------------------------------------------------------
Please note. This is the first pull request from me.
My public GPG key is available here
https://keys.openpgp.org/vks/v1/by-fingerprint/CDB5BEEF8837142579F5CDFE8E927E10F72F78D4

----------------------------------------------------------------
scripts: add a new script for machine development

----------------------------------------------------------------

Maksim Davydov (4):
  qom: add default value
  qmp: add dump machine type compatibility properties
  python/qemu/machine: add method to retrieve QEMUMachine::binary field
  scripts: add script to compare compatibility properties

 MAINTAINERS                      |   5 +
 hw/core/machine-qmp-cmds.c       |  23 +-
 python/qemu/machine/machine.py   |   5 +
 qapi/machine.json                |  67 ++++-
 qom/qom-qmp-cmds.c               |   1 +
 scripts/compare-machine-types.py | 486 +++++++++++++++++++++++++++++++
 tests/qtest/fuzz/qos_fuzz.c      |   2 +-
 7 files changed, 585 insertions(+), 4 deletions(-)
 create mode 100755 scripts/compare-machine-types.py

-- 
2.34.1

Re: [PULL v2 0/4] machine development tool

Posted by Peter Maydell 1 month, 1 week ago

On Mon, 18 Mar 2024 at 21:36, Maksim Davydov <davydov-max@yandex-team.ru> wrote:
>
> The following changes since commit ba49d760eb04630e7b15f423ebecf6c871b8f77b:
>
>   Merge tag 'pull-maintainer-final-130324-1' of https://gitlab.com/stsquad/qemu into staging (2024-03-13 15:12:14 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/davydov-max/qemu.git tags/pull-compare-mt-2024-03-19
>
> for you to fetch changes up to e12b89f71ba5b93877b6a3adc379a6369d0c9bab:
>
>   scripts: add script to compare compatibility properties (2024-03-19 00:13:54 +0300)
>
> ----------------------------------------------------------------
> Please note. This is the first pull request from me.
> My public GPG key is available here
> https://keys.openpgp.org/vks/v1/by-fingerprint/CDB5BEEF8837142579F5CDFE8E927E10F72F78D4
>
> ----------------------------------------------------------------
> scripts: add a new script for machine development
>

I said I wanted this to go via some other sub-maintainer's tree.
Please don't keep submitting direct pull requests for it.
QEMU's development flow does not generally involve people
directly submitting pull requests for patches they have written.

thanks
-- PMM

Re: [PULL v2 0/4] machine development tool

Posted by Philippe Mathieu-Daudé 1 month, 1 week ago

Hi Maksim,

On 19/3/24 11:24, Peter Maydell wrote:
> On Mon, 18 Mar 2024 at 21:36, Maksim Davydov <davydov-max@yandex-team.ru> wrote:
>>
>> The following changes since commit ba49d760eb04630e7b15f423ebecf6c871b8f77b:
>>
>>    Merge tag 'pull-maintainer-final-130324-1' of https://gitlab.com/stsquad/qemu into staging (2024-03-13 15:12:14 +0000)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/davydov-max/qemu.git tags/pull-compare-mt-2024-03-19
>>
>> for you to fetch changes up to e12b89f71ba5b93877b6a3adc379a6369d0c9bab:
>>
>>    scripts: add script to compare compatibility properties (2024-03-19 00:13:54 +0300)
>>
>> ----------------------------------------------------------------
>> Please note. This is the first pull request from me.
>> My public GPG key is available here
>> https://keys.openpgp.org/vks/v1/by-fingerprint/CDB5BEEF8837142579F5CDFE8E927E10F72F78D4
>>
>> ----------------------------------------------------------------
>> scripts: add a new script for machine development
>>
> 
> I said I wanted this to go via some other sub-maintainer's tree.

I'm OK to take the first 3 machine-core patches, but the
tree is currently frozen to stabilize before the next release.
Since your patches add a new feature, I'll merge them once the
tree re-opens in ~1 month, see the announced schedule:
https://lore.kernel.org/qemu-devel/CAFEAcA_ncrw8nsD50Ov=Fse=gYFw3CabpURWM9yK3yWmL5CTQw@mail.gmail.com/

I haven't looked at the last patch yet, at a glance I'm not objecting
to it, but having an Ack-by tag by John (Python maintainer) would be nice.

Regards,

Phil.