I recently wanted to check for some changes that I did to the URI handling
in the block layer code, but I had to discover that a lot of iotests only
work with the raw file format when using a protocol that is not "file",
i.e. "./check -ssh -qcow2" shows a lot of failures.
While some tests could be fixed to work with the "ssh" protocol, too,
many other tests seem to be written for the "file" protocol only and
thus have to be marked accordingly.

After applying these patches, there is still one failure left in test 181
where I'm unsure whether it's a real bug or whether this test should also
simply be marked to work with the "file" protocol only. Suggestions are
welcome!

Thomas Huth (9):
  tests/qemu-iotests: Fix test 033 for running with non-file protocols
  tests/qemu-iotests: Restrict test 066 to the 'file' protocol
  tests/qemu-iotests: Restrict test 114 to the 'file' protocol
  tests/qemu-iotests: Restrict test 130 to the 'file' protocol
  tests/qemu-iotests: Restrict test 134 and 158 to the 'file' protocol
  tests/qemu-iotests: Restrict test 156 to the 'file' protocol
  tests/qemu-iotests: Restrict tests that use --image-opts to the 'file'
    protocol
  tests/qemu-iotests: Fix some tests that use --image-opts for other
    protocols
  tests/qemu-iotests: Restrict tests using "--blockdev file" to the file
    protocol

 tests/qemu-iotests/033                                | 6 +++---
 tests/qemu-iotests/066                                | 2 +-
 tests/qemu-iotests/114                                | 2 +-
 tests/qemu-iotests/130                                | 2 +-
 tests/qemu-iotests/134                                | 2 +-
 tests/qemu-iotests/156                                | 2 +-
 tests/qemu-iotests/158                                | 2 +-
 tests/qemu-iotests/188                                | 2 +-
 tests/qemu-iotests/189                                | 2 +-
 tests/qemu-iotests/198                                | 2 +-
 tests/qemu-iotests/263                                | 6 ++++--
 tests/qemu-iotests/284                                | 7 +++----
 tests/qemu-iotests/tests/detect-zeroes-registered-buf | 4 +++-
 tests/qemu-iotests/tests/qcow2-internal-snapshots     | 2 +-
 tests/qemu-iotests/tests/qsd-jobs                     | 2 +-
 15 files changed, 24 insertions(+), 21 deletions(-)

-- 
2.44.0

Am 15.03.2024 um 12:10 hat Thomas Huth geschrieben:
> I recently wanted to check for some changes that I did to the URI handling
> in the block layer code, but I had to discover that a lot of iotests only
> work with the raw file format when using a protocol that is not "file",
> i.e. "./check -ssh -qcow2" shows a lot of failures.
> While some tests could be fixed to work with the "ssh" protocol, too,
> many other tests seem to be written for the "file" protocol only and
> thus have to be marked accordingly.
> 
> After applying these patches, there is still one failure left in test 181
> where I'm unsure whether it's a real bug or whether this test should also
> simply be marked to work with the "file" protocol only. Suggestions are
> welcome!
> 
> Thomas Huth (9):
>   tests/qemu-iotests: Fix test 033 for running with non-file protocols
>   tests/qemu-iotests: Restrict test 066 to the 'file' protocol
>   tests/qemu-iotests: Restrict test 114 to the 'file' protocol
>   tests/qemu-iotests: Restrict test 130 to the 'file' protocol
>   tests/qemu-iotests: Restrict test 134 and 158 to the 'file' protocol
>   tests/qemu-iotests: Restrict test 156 to the 'file' protocol
>   tests/qemu-iotests: Restrict tests that use --image-opts to the 'file'
>     protocol
>   tests/qemu-iotests: Fix some tests that use --image-opts for other
>     protocols
>   tests/qemu-iotests: Restrict tests using "--blockdev file" to the file
>     protocol

Thanks, applied to the block branch.

Kevin