[PATCH] docs/about/deprecated.rst: Move SMP configurations item to system emulator section

Zhao Liu posted 1 patch 1 month, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240312071512.3283513-1-zhao1.liu@linux.intel.com
docs/about/deprecated.rst | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
[PATCH] docs/about/deprecated.rst: Move SMP configurations item to system emulator section
Posted by Zhao Liu 1 month, 2 weeks ago
From: Zhao Liu <zhao1.liu@intel.com>

In the commit 54c4ea8f3ae6 ("hw/core/machine-smp: Deprecate unsupported
'parameter=1' SMP configurations"), the SMP related item is put under
the section "User-mode emulator command line arguments" instead of
"System emulator command line arguments".

-smp is a system emulator command, so move SMP configurations item to
system emulator section.

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
based on 7489f7f3f81d.

Note: the git diff understood my move of SMP item as the move of the
whole "User-mode emulator command line arguments" section, which may
cause confusion about the contents of this patch.
---
 docs/about/deprecated.rst | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index dfd681cd024e..2f9277c9158c 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -47,16 +47,6 @@ as short-form boolean values, and passed to plugins as ``arg_name=on``.
 However, short-form booleans are deprecated and full explicit ``arg_name=on``
 form is preferred.
 
-User-mode emulator command line arguments
------------------------------------------
-
-``-p`` (since 9.0)
-''''''''''''''''''
-
-The ``-p`` option pretends to control the host page size.  However,
-it is not possible to change the host page size, and using the
-option only causes failures.
-
 ``-smp`` (Unsupported "parameter=1" SMP configurations) (since 9.0)
 '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
 
@@ -71,6 +61,16 @@ configurations (e.g. -smp drawers=1,books=1,clusters=1 for x86 PC machine) is
 marked deprecated since 9.0, users have to ensure that all the topology members
 described with -smp are supported by the target machine.
 
+User-mode emulator command line arguments
+-----------------------------------------
+
+``-p`` (since 9.0)
+''''''''''''''''''
+
+The ``-p`` option pretends to control the host page size.  However,
+it is not possible to change the host page size, and using the
+option only causes failures.
+
 QEMU Machine Protocol (QMP) commands
 ------------------------------------
 
-- 
2.34.1
Re: [PATCH] docs/about/deprecated.rst: Move SMP configurations item to system emulator section
Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago
On 12/3/24 08:15, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> In the commit 54c4ea8f3ae6 ("hw/core/machine-smp: Deprecate unsupported
> 'parameter=1' SMP configurations"), the SMP related item is put under
> the section "User-mode emulator command line arguments" instead of
> "System emulator command line arguments".
> 
> -smp is a system emulator command, so move SMP configurations item to
> system emulator section.
> 
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> based on 7489f7f3f81d.
> 
> Note: the git diff understood my move of SMP item as the move of the
> whole "User-mode emulator command line arguments" section, which may
> cause confusion about the contents of this patch.

Oops my bad I guess :/

Thanks, patch queued!

> ---
>   docs/about/deprecated.rst | 20 ++++++++++----------
>   1 file changed, 10 insertions(+), 10 deletions(-)
Re: [PATCH] docs/about/deprecated.rst: Move SMP configurations item to system emulator section
Posted by Thomas Huth 1 month, 2 weeks ago
On 12/03/2024 08.15, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> In the commit 54c4ea8f3ae6 ("hw/core/machine-smp: Deprecate unsupported
> 'parameter=1' SMP configurations"), the SMP related item is put under
> the section "User-mode emulator command line arguments" instead of
> "System emulator command line arguments".
> 
> -smp is a system emulator command, so move SMP configurations item to
> system emulator section.
> 
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> based on 7489f7f3f81d.
> 
> Note: the git diff understood my move of SMP item as the move of the
> whole "User-mode emulator command line arguments" section, which may
> cause confusion about the contents of this patch.
> ---
>   docs/about/deprecated.rst | 20 ++++++++++----------
>   1 file changed, 10 insertions(+), 10 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>