plugins/howvec: fix use-after-free

[PATCH] plugins/howvec: fix use-after-free

Pierrick Bouvier posted 1 patch 8 months, 2 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240311060456.218190-1-pierrick.bouvier@linaro.org

Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>, Pierrick Bouvier <pierrick.bouvier@linaro.org>

contrib/plugins/howvec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] plugins/howvec: fix use-after-free

Posted by Pierrick Bouvier 8 months, 2 weeks ago

reported by coverity scan
---
 contrib/plugins/howvec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/plugins/howvec.c b/contrib/plugins/howvec.c
index 2d10c87e0fb..5be91f6fc5c 100644
--- a/contrib/plugins/howvec.c
+++ b/contrib/plugins/howvec.c
@@ -168,8 +168,8 @@ static void free_record(gpointer data)
 {
     InsnExecCount *rec = (InsnExecCount *) data;
     g_free(rec->insn);
-    g_free(rec);
     qemu_plugin_scoreboard_free(rec->count.score);
+    g_free(rec);
 }
 
 static void plugin_exit(qemu_plugin_id_t id, void *p)
-- 
2.39.2

Re: [PATCH] plugins/howvec: fix use-after-free

Posted by Philippe Mathieu-Daudé 8 months, 2 weeks ago

On 11/3/24 07:04, Pierrick Bouvier wrote:
> reported by coverity scan

Reported by Coverity as CID 1539967.

> ---
>   contrib/plugins/howvec.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/contrib/plugins/howvec.c b/contrib/plugins/howvec.c
> index 2d10c87e0fb..5be91f6fc5c 100644
> --- a/contrib/plugins/howvec.c
> +++ b/contrib/plugins/howvec.c
> @@ -168,8 +168,8 @@ static void free_record(gpointer data)
>   {
>       InsnExecCount *rec = (InsnExecCount *) data;
>       g_free(rec->insn);
> -    g_free(rec);
>       qemu_plugin_scoreboard_free(rec->count.score);
> +    g_free(rec);
>   }
>   
>   static void plugin_exit(qemu_plugin_id_t id, void *p)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>