tests/vm: ensure we build everything by default

[RFC PATCH] tests/vm: ensure we build everything by default

Alex Bennée posted 1 patch 1 month, 2 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240309115726.1107020-1-alex.bennee@linaro.org

Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>

tests/vm/basevm.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[RFC PATCH] tests/vm: ensure we build everything by default

Posted by Alex Bennée 1 month, 2 weeks ago

The "check" target by itself is not enough to ensure we build the user
mode binaries. While we can't test them with check-tcg we can at least
include them in the build.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Richard Henderson <richard.henderson@linaro.org>
Cc: Gustavo Romero <gustavo.romero@linaro.org>
---
 tests/vm/basevm.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index f8fd751eb1..4a1af04b9a 100644
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -606,7 +606,7 @@ def get_default_jobs():
     parser.add_argument("--build-qemu",
                         help="build QEMU from source in guest")
     parser.add_argument("--build-target",
-                        help="QEMU build target", default="check")
+                        help="QEMU build target", default="all check")
     parser.add_argument("--build-path", default=None,
                         help="Path of build directory, "\
                         "for using build tree QEMU binary. ")
-- 
2.39.2

Re: [RFC PATCH] tests/vm: ensure we build everything by default

Posted by Thomas Huth 1 month, 2 weeks ago

On 09/03/2024 12.57, Alex Bennée wrote:
> The "check" target by itself is not enough to ensure we build the user
> mode binaries. While we can't test them with check-tcg we can at least
> include them in the build.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: Gustavo Romero <gustavo.romero@linaro.org>
> ---
>   tests/vm/basevm.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Thomas Huth <thuth@redhat.com>