[v1] Sparc CPU naming and help text improvements

[PATCH 0/5] Sparc CPU naming and help text improvements

Posted by Thomas Huth 1 month, 3 weeks ago

The Sparc CPU naming and the corresponding help text is somewhat
confusing for the users. We should avoid spaces in the Names and
provide clear information to the users what can be passed to the
"-cpu" option.
While we're at it, also remove the "+" from two of the CPU names
since this character is now not allowed in device names anymore
(and was worked around with an ugly hack in qom/object.c so far).

Thomas Huth (5):
  target/sparc/cpu: Rename the CPU models with a "+" in their names
  target/sparc/cpu: Avoid spaces by default in the CPU names
  target/sparc/cpu: Improve the CPU help text
  docs/system/target-sparc: Improve the Sparc documentation
  docs/about: Deprecate the old "UltraSparc" CPU names that contain a
    "+"

 docs/about/deprecated.rst    |  9 +++++
 docs/system/target-sparc.rst |  8 +++-
 qom/object.c                 |  8 ----
 target/sparc/cpu.c           | 71 +++++++++++++++++++++---------------
 4 files changed, 56 insertions(+), 40 deletions(-)

-- 
2.44.0

Re: [PATCH 0/5] Sparc CPU naming and help text improvements

Posted by Thomas Huth 1 week, 6 days ago

On 07/03/2024 18.43, Thomas Huth wrote:
> The Sparc CPU naming and the corresponding help text is somewhat
> confusing for the users. We should avoid spaces in the Names and
> provide clear information to the users what can be passed to the
> "-cpu" option.
> While we're at it, also remove the "+" from two of the CPU names
> since this character is now not allowed in device names anymore
> (and was worked around with an ugly hack in qom/object.c so far).
> 
> Thomas Huth (5):
>    target/sparc/cpu: Rename the CPU models with a "+" in their names
>    target/sparc/cpu: Avoid spaces by default in the CPU names
>    target/sparc/cpu: Improve the CPU help text
>    docs/system/target-sparc: Improve the Sparc documentation
>    docs/about: Deprecate the old "UltraSparc" CPU names that contain a
>      "+"

Ping!

Mark, Aryom, could you please comment on this patch series, too?

Thanks,
  Thomas

Re: [PATCH 0/5] Sparc CPU naming and help text improvements

Posted by Mark Cave-Ayland 1 week, 2 days ago

On 15/04/2024 08:26, Thomas Huth wrote:

> On 07/03/2024 18.43, Thomas Huth wrote:
>> The Sparc CPU naming and the corresponding help text is somewhat
>> confusing for the users. We should avoid spaces in the Names and
>> provide clear information to the users what can be passed to the
>> "-cpu" option.
>> While we're at it, also remove the "+" from two of the CPU names
>> since this character is now not allowed in device names anymore
>> (and was worked around with an ugly hack in qom/object.c so far).
>>
>> Thomas Huth (5):
>>    target/sparc/cpu: Rename the CPU models with a "+" in their names
>>    target/sparc/cpu: Avoid spaces by default in the CPU names
>>    target/sparc/cpu: Improve the CPU help text
>>    docs/system/target-sparc: Improve the Sparc documentation
>>    docs/about: Deprecate the old "UltraSparc" CPU names that contain a
>>      "+"
> 
> Ping!
> 
> Mark, Aryom, could you please comment on this patch series, too?
> 
> Thanks,
>   Thomas

Done! I didn't realise that it was only patches 1 and 2 that were still outstanding 
until I tested the series, so I've replied to those separately.


ATB,

Mark.

Re: [PATCH 0/5] Sparc CPU naming and help text improvements

Posted by Mark Cave-Ayland 1 week, 2 days ago

On 18/04/2024 21:08, Mark Cave-Ayland wrote:

> On 15/04/2024 08:26, Thomas Huth wrote:
> 
>> On 07/03/2024 18.43, Thomas Huth wrote:
>>> The Sparc CPU naming and the corresponding help text is somewhat
>>> confusing for the users. We should avoid spaces in the Names and
>>> provide clear information to the users what can be passed to the
>>> "-cpu" option.
>>> While we're at it, also remove the "+" from two of the CPU names
>>> since this character is now not allowed in device names anymore
>>> (and was worked around with an ugly hack in qom/object.c so far).
>>>
>>> Thomas Huth (5):
>>>    target/sparc/cpu: Rename the CPU models with a "+" in their names
>>>    target/sparc/cpu: Avoid spaces by default in the CPU names
>>>    target/sparc/cpu: Improve the CPU help text
>>>    docs/system/target-sparc: Improve the Sparc documentation
>>>    docs/about: Deprecate the old "UltraSparc" CPU names that contain a
>>>      "+"
>>
>> Ping!
>>
>> Mark, Aryom, could you please comment on this patch series, too?
>>
>> Thanks,
>>   Thomas
> 
> Done! I didn't realise that it was only patches 1 and 2 that were still outstanding 
> until I tested the series, so I've replied to those separately.

Oops actually that's not quite right: looks like my git-am failed on patch 3 because 
it was already applied, but the remaining 2 patches are still relevant. I've just 
replied to those too.


ATB,

Mark.