On 08.03.24 08:36, Peter Xu wrote:
> On Thu, Mar 07, 2024 at 03:37:06PM +0000, Jonathan Cameron wrote:
>> v2: (Thanks to Peter Xu for reviewing!)
>> - New patch 1 to rename addr1 to mr_addr in the interests of meaningful naming.
>> - Take advantage of a cached address space only allow for a single MR to simplify
>> the new code.
>> - Various cleanups of indentation etc.
>> - Cover letter and some patch descriptions updated to reflect changes.
>> - Changes all called out in specific patches.
>
> All look good to me, thanks. Having the new functions' first argument as
> MemTxAttrs is slightly weird to me, but that's not a big deal and we can
> clean it up later if wanted. I guess it's good to fix this in 9.0 first as
> it's a real bug even if not trivial to hit.
>
> I queued it in my migration tree (with my "memory API" hat..).
>
> I won't send a pull until next Monday. Please shoot if there's any objections!
>
Works for me, thanks!
--
Cheers,
David / dhildenb