[PATCH 05/14] tests/unit/test-smp-parse: Drop the unsupported "dies=1" case

Zhao Liu posted 14 patches 8 months, 3 weeks ago
There is a newer version of this series
[PATCH 05/14] tests/unit/test-smp-parse: Drop the unsupported "dies=1" case
Posted by Zhao Liu 8 months, 3 weeks ago
From: Zhao Liu <zhao1.liu@intel.com>

Unsupported "parameter=1" SMP configurations is marked as deprecated,
so drop the related test case.

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
 tests/unit/test-smp-parse.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c
index 24972666a74d..1874bea08609 100644
--- a/tests/unit/test-smp-parse.c
+++ b/tests/unit/test-smp-parse.c
@@ -607,11 +607,6 @@ static void test_generic_valid(const void *opaque)
         unsupported_params_init(mc, &data);
 
         smp_parse_test(ms, &data, true);
-
-        /* Unsupported parameters can be provided with their values as 1 */
-        data.config.has_dies = true;
-        data.config.dies = 1;
-        smp_parse_test(ms, &data, true);
     }
 
     object_unref(obj);
-- 
2.34.1
Re: [PATCH 05/14] tests/unit/test-smp-parse: Drop the unsupported "dies=1" case
Posted by Thomas Huth 8 months, 3 weeks ago
On 06/03/2024 10.53, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> Unsupported "parameter=1" SMP configurations is marked as deprecated,
> so drop the related test case.
> 
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>   tests/unit/test-smp-parse.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c
> index 24972666a74d..1874bea08609 100644
> --- a/tests/unit/test-smp-parse.c
> +++ b/tests/unit/test-smp-parse.c
> @@ -607,11 +607,6 @@ static void test_generic_valid(const void *opaque)
>           unsupported_params_init(mc, &data);
>   
>           smp_parse_test(ms, &data, true);
> -
> -        /* Unsupported parameters can be provided with their values as 1 */
> -        data.config.has_dies = true;
> -        data.config.dies = 1;
> -        smp_parse_test(ms, &data, true);
>       }
>   
>       object_unref(obj);

Reviewed-by: Thomas Huth <thuth@redhat.com>