[PATCH] qemu-options.hx: Fix uncorrect description of "-serial"

steven.shen@jaguarmicro.com posted 1 patch 8 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240305013016.2268-1-steven.shen@jaguarmicro.com
qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] qemu-options.hx: Fix uncorrect description of "-serial"
Posted by steven.shen@jaguarmicro.com 8 months, 3 weeks ago
Before v2.12, serial_hds used MAX_SERIAL_PORTS(4) for
resources of serials.The limitaion description of "-serial"
option: "This option can be used several times to simulate
up to 4 serial ports."
In latest qemu, serial_hds have been replaced by "Chardev **"
and now is dynamically allocated through "g_renew".
So the limitation description is not suitable now.
Update to "This option can be used several times to simulate
multiple serial ports." to avoid misleading.

Signed-off-by: Steven Shen <steven.shen@jaguarmicro.com>
---
 qemu-options.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 9a47385c15..ac4a30fa83 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -4129,7 +4129,7 @@ SRST
     default device is ``vc`` in graphical mode and ``stdio`` in non
     graphical mode.
 
-    This option can be used several times to simulate up to 4 serial
+    This option can be used several times to simulate multiple serial
     ports.
 
     You can use ``-serial none`` to suppress the creation of default
-- 
2.36.0.windows.1
Re: [PATCH] qemu-options.hx: Fix uncorrect description of "-serial"
Posted by Peter Maydell 8 months, 3 weeks ago
On Tue, 5 Mar 2024 at 01:31, steven.shen@jaguarmicro.com
<steven.shen@jaguarmicro.com> wrote:
>
> Before v2.12, serial_hds used MAX_SERIAL_PORTS(4) for
> resources of serials.The limitaion description of "-serial"
> option: "This option can be used several times to simulate
> up to 4 serial ports."
> In latest qemu, serial_hds have been replaced by "Chardev **"
> and now is dynamically allocated through "g_renew".
> So the limitation description is not suitable now.
> Update to "This option can be used several times to simulate
> multiple serial ports." to avoid misleading.
>
> Signed-off-by: Steven Shen <steven.shen@jaguarmicro.com>

Thanks for this documentation fix! I've applied it to target-arm.next
(with some tweaks to the commit message), so it should appear in
upstream git within a week or so.

-- PMM