For a long time, we provide two compression formats in the
download area, .bz2 and .xz.  There's absolutely no reason
to provide two in parallel, .xz compresses better, and all
the links we use points to .xz.  Downstream distributions
mostly use .xz too.

For the release maintenance providing two formats is definitely
extra burden too.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 scripts/make-release | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/make-release b/scripts/make-release
index 9c570b87f4..6e0433de24 100755
--- a/scripts/make-release
+++ b/scripts/make-release
@@ -47,5 +47,5 @@ meson subprojects download $SUBPROJECTS
         CryptoPkg/Library/OpensslLib/openssl \
         MdeModulePkg/Library/BrotliCustomDecompressLib/brotli)
 popd
-tar --exclude=.git -cjf ${destination}.tar.bz2 ${destination}
+tar --exclude=.git -cJf ${destination}.tar.xz ${destination}
 rm -rf ${destination}
-- 
2.39.2

On Mon, 4 Mar 2024 at 13:52, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> For a long time, we provide two compression formats in the
> download area, .bz2 and .xz.  There's absolutely no reason
> to provide two in parallel, .xz compresses better, and all
> the links we use points to .xz.  Downstream distributions
> mostly use .xz too.
>
> For the release maintenance providing two formats is definitely
> extra burden too.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  scripts/make-release | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

> diff --git a/scripts/make-release b/scripts/make-release
> index 9c570b87f4..6e0433de24 100755
> --- a/scripts/make-release
> +++ b/scripts/make-release
> @@ -47,5 +47,5 @@ meson subprojects download $SUBPROJECTS
>          CryptoPkg/Library/OpensslLib/openssl \
>          MdeModulePkg/Library/BrotliCustomDecompressLib/brotli)
>  popd
> -tar --exclude=.git -cjf ${destination}.tar.bz2 ${destination}
> +tar --exclude=.git -cJf ${destination}.tar.xz ${destination}
>  rm -rf ${destination}
> --
> 2.39.2
>
>

On Mon, 4 Mar 2024 at 18:52, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> For a long time, we provide two compression formats in the
> download area, .bz2 and .xz.  There's absolutely no reason
> to provide two in parallel, .xz compresses better, and all
> the links we use points to .xz.  Downstream distributions
> mostly use .xz too.

Seems reasonable. Out of curiosity, do we have the
download stats on how many .xz vs .bz2 downloads we get?
Stefan or Paolo, do you have the webserver info?
(Probably not worth bothering if it's a big pain to
get the data.)

thanks
-- PMM

On Tue, 5 Mar 2024 at 04:52, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Mon, 4 Mar 2024 at 18:52, Michael Tokarev <mjt@tls.msk.ru> wrote:
> >
> > For a long time, we provide two compression formats in the
> > download area, .bz2 and .xz.  There's absolutely no reason
> > to provide two in parallel, .xz compresses better, and all
> > the links we use points to .xz.  Downstream distributions
> > mostly use .xz too.
>
> Seems reasonable. Out of curiosity, do we have the
> download stats on how many .xz vs .bz2 downloads we get?
> Stefan or Paolo, do you have the webserver info?
> (Probably not worth bothering if it's a big pain to
> get the data.)

I don't have access to the CDN stats. Maybe Paolo does.

Stefan

On Mon, Mar 04, 2024 at 09:51:49PM +0300, Michael Tokarev wrote:
> For a long time, we provide two compression formats in the
> download area, .bz2 and .xz.  There's absolutely no reason
> to provide two in parallel, .xz compresses better, and all
> the links we use points to .xz.  Downstream distributions
> mostly use .xz too.
> 
> For the release maintenance providing two formats is definitely
> extra burden too.
> 
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  scripts/make-release | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|