[v1] contrib/elf2dmp: Improve robustness

[PATCH 0/7] contrib/elf2dmp: Improve robustness

Akihiko Odaki posted 7 patches 8 months, 3 weeks ago

Diff against v2 v3 v4
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240303-elf2dmp-v1-0-bea6649fe3e6@daynix.com

Maintainers: Viktor Prutyanov <viktor.prutyanov@phystech.edu>, Akihiko Odaki <akihiko.odaki@daynix.com>

There is a newer version of this series

MAINTAINERS                 |  1 +
contrib/elf2dmp/addrspace.c | 51 ++++++++++++++++++++++++++++-----------------
contrib/elf2dmp/main.c      | 25 +++++++---------------
contrib/elf2dmp/pdb.c       |  3 ++-
4 files changed, 43 insertions(+), 37 deletions(-)

Expand all Fold all

[PATCH 0/7] contrib/elf2dmp: Improve robustness

Posted by Akihiko Odaki 8 months, 3 weeks ago

elf2dmp sometimes fails to work with partially corrupted dumps, and also
emits warnings when sanitizers are in use. This series are collections
of changes to improve the situation.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
Akihiko Odaki (7):
      contrib/elf2dmp: Always check for PA resolution failure
      contrib/elf2dmp: Always destroy PA space
      contrib/elf2dmp: Ensure segment fits in file
      contrib/elf2dmp: Use lduw_le_p() to read PDB
      contrib/elf2dmp: Use rol64() to decode
      contrib/elf2dmp: Continue even contexts are lacking
      MAINTAINERS: Add Akihiko Odaki as a elf2dmp reviewer

 MAINTAINERS                 |  1 +
 contrib/elf2dmp/addrspace.c | 51 ++++++++++++++++++++++++++++-----------------
 contrib/elf2dmp/main.c      | 25 +++++++---------------
 contrib/elf2dmp/pdb.c       |  3 ++-
 4 files changed, 43 insertions(+), 37 deletions(-)
---
base-commit: bfe8020c814a30479a4241aaa78b63960655962b
change-id: 20240301-elf2dmp-1a6a551f8663

Best regards,
-- 
Akihiko Odaki <akihiko.odaki@daynix.com>

Re: [PATCH 0/7] contrib/elf2dmp: Improve robustness

Posted by Peter Maydell 8 months, 3 weeks ago

On Sun, 3 Mar 2024 at 10:51, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> elf2dmp sometimes fails to work with partially corrupted dumps, and also
> emits warnings when sanitizers are in use. This series are collections
> of changes to improve the situation.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> Akihiko Odaki (7):
>       contrib/elf2dmp: Always check for PA resolution failure
>       contrib/elf2dmp: Always destroy PA space
>       contrib/elf2dmp: Ensure segment fits in file
>       contrib/elf2dmp: Use lduw_le_p() to read PDB
>       contrib/elf2dmp: Use rol64() to decode
>       contrib/elf2dmp: Continue even contexts are lacking
>       MAINTAINERS: Add Akihiko Odaki as a elf2dmp reviewer
>

I noticed somebody filed a bug report about elf2dmp
crashing recently:

https://gitlab.com/qemu-project/qemu/-/issues/2202

Does this patchset happen to fix that crash?

thanks
-- PMM