[v1] target/sparc: Implement VIS4

[PATCH 41/41] target/sparc: Enable VIS4 feature bit

Posted by Richard Henderson 8 months, 4 weeks ago

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/sparc/cpu.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c
index 18dfd90845..1ffac3dd8a 100644
--- a/target/sparc/cpu.c
+++ b/target/sparc/cpu.c
@@ -554,6 +554,7 @@ static const char * const feature_name[] = {
     [CPU_FEATURE_BIT_FMAF] = "fmaf",
     [CPU_FEATURE_BIT_VIS3] = "vis3",
     [CPU_FEATURE_BIT_IMA] = "ima",
+    [CPU_FEATURE_BIT_VIS4] = "vis4",
 #else
     [CPU_FEATURE_BIT_MUL] = "mul",
     [CPU_FEATURE_BIT_DIV] = "div",
@@ -882,6 +883,8 @@ static Property sparc_cpu_properties[] = {
                     CPU_FEATURE_BIT_VIS3, false),
     DEFINE_PROP_BIT("ima",      SPARCCPU, env.def.features,
                     CPU_FEATURE_BIT_IMA, false),
+    DEFINE_PROP_BIT("vis4",     SPARCCPU, env.def.features,
+                    CPU_FEATURE_BIT_VIS4, false),
 #else
     DEFINE_PROP_BIT("mul",      SPARCCPU, env.def.features,
                     CPU_FEATURE_BIT_MUL, false),
-- 
2.34.1

Re: [PATCH 41/41] target/sparc: Enable VIS4 feature bit

Posted by Philippe Mathieu-Daudé 6 months, 2 weeks ago

On 2/3/24 06:16, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   target/sparc/cpu.c | 3 +++
>   1 file changed, 3 insertions(+)


> @@ -882,6 +883,8 @@ static Property sparc_cpu_properties[] = {
>                       CPU_FEATURE_BIT_VIS3, false),
>       DEFINE_PROP_BIT("ima",      SPARCCPU, env.def.features,
>                       CPU_FEATURE_BIT_IMA, false),
> +    DEFINE_PROP_BIT("vis4",     SPARCCPU, env.def.features,
> +                    CPU_FEATURE_BIT_VIS4, false),

I don't see any current CPU with this bit enabled. Nitpicking,
maybe use "Allow enabling VIS4 feature" as subject? (I suppose
you tried using -cpu foo,vis4=on).

Could we add the M7 to sparc_defs[]?

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH 41/41] target/sparc: Enable VIS4 feature bit

Posted by Philippe Mathieu-Daudé 6 months, 2 weeks ago

On 10/5/24 19:16, Philippe Mathieu-Daudé wrote:
> On 2/3/24 06:16, Richard Henderson wrote:
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>>   target/sparc/cpu.c | 3 +++
>>   1 file changed, 3 insertions(+)
> 
> 
>> @@ -882,6 +883,8 @@ static Property sparc_cpu_properties[] = {
>>                       CPU_FEATURE_BIT_VIS3, false),
>>       DEFINE_PROP_BIT("ima",      SPARCCPU, env.def.features,
>>                       CPU_FEATURE_BIT_IMA, false),
>> +    DEFINE_PROP_BIT("vis4",     SPARCCPU, env.def.features,
>> +                    CPU_FEATURE_BIT_VIS4, false),
> 
> I don't see any current CPU with this bit enabled. Nitpicking,
> maybe use "Allow enabling VIS4 feature" as subject? (I suppose
> you tried using -cpu foo,vis4=on).

Doh this is what you mentioned in the cover letter...

> Could we add the M7 to sparc_defs[]?
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>