[v1] plugins/execlog: add data address match and address range support

[PATCH 0/4] plugins/execlog: add data address match and address range support

Posted by Sven Schnelle 9 months ago

Hi List,

this patchset adds a new -dfilter option and address range matching. With this
execlog can match only a certain range of address for both instruction and
data adresses.

Example usage:

qemu-system-xxx <other options> -d plugin -plugin libexeclog.so,afilter=0x1000-0x2000,dfilter=0x388

This would only log instruction in the address range 0x1000 to 0x2000
and accessing data at address 0x388.

Sven Schnelle (4):
  plugins/execlog: add struct execlog_ctx
  plugins/execlog: pass matches array to parse_vaddr_match
  plugins/execlog: add data address match
  plugins/execlog: add address range matching

 contrib/plugins/execlog.c | 102 ++++++++++++++++++++++++++++++--------
 1 file changed, 82 insertions(+), 20 deletions(-)

-- 
2.43.2

Re: [PATCH 0/4] plugins/execlog: add data address match and address range support

Posted by Pierrick Bouvier 9 months ago

Hi Sven, thanks for your series.

Yesterday, series for new API to access registers from plugins was 
merged. As part of it, execlog plugin was extended to support this [1].
This conflict with the changes presented here.

Could you please rebase this series on top of master?

Thanks,
Pierrick

[1] 
https://gitlab.com/qemu-project/qemu/-/commit/af6e4e0a22c18a7cc97650caec56ed99c9899dd7

On 2/29/24 12:02 AM, Sven Schnelle wrote:
> Hi List,
> 
> this patchset adds a new -dfilter option and address range matching. With this
> execlog can match only a certain range of address for both instruction and
> data adresses.
> 
> Example usage:
> 
> qemu-system-xxx <other options> -d plugin -plugin libexeclog.so,afilter=0x1000-0x2000,dfilter=0x388
> 
> This would only log instruction in the address range 0x1000 to 0x2000
> and accessing data at address 0x388.
> 
> Sven Schnelle (4):
>    plugins/execlog: add struct execlog_ctx
>    plugins/execlog: pass matches array to parse_vaddr_match
>    plugins/execlog: add data address match
>    plugins/execlog: add address range matching
> 
>   contrib/plugins/execlog.c | 102 ++++++++++++++++++++++++++++++--------
>   1 file changed, 82 insertions(+), 20 deletions(-)
>

Re: [PATCH 0/4] plugins/execlog: add data address match and address range support

Posted by Sven Schnelle 9 months ago

Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:

> Hi Sven, thanks for your series.
>
> Yesterday, series for new API to access registers from plugins was
> merged. As part of it, execlog plugin was extended to support this
> [1].
> This conflict with the changes presented here.
>
> Could you please rebase this series on top of master?

I sent out a rebased version. Should have done a git pull before...

Thanks,
Sven