[v3] backup: discard-source parameter

[PATCH v3 0/5] backup: discard-source parameter

Vladimir Sementsov-Ogievskiy posted 5 patches 9 months ago

Diff against v1 v2 v4
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240228141501.455989-1-vsementsov@yandex-team.ru

Maintainers: John Snow <jsnow@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Wen Congyang <wencongyang2@huawei.com>, Xie Changlong <xiechanglong.d@gmail.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>

There is a newer version of this series

block/backup.c                                |   5 +-
block/block-copy.c                            |  12 +-
block/copy-before-write.c                     |  39 ++++-
block/copy-before-write.h                     |   1 +
block/replication.c                           |   4 +-
blockdev.c                                    |   2 +-
include/block/block-common.h                  |   2 +
include/block/block-copy.h                    |   2 +
include/block/block_int-global-state.h        |   2 +-
qapi/block-core.json                          |   4 +
tests/qemu-iotests/257.out                    | 112 ++++++-------
.../qemu-iotests/tests/backup-discard-source  | 151 ++++++++++++++++++
.../tests/backup-discard-source.out           |   5 +
13 files changed, 271 insertions(+), 70 deletions(-)
create mode 100755 tests/qemu-iotests/tests/backup-discard-source
create mode 100644 tests/qemu-iotests/tests/backup-discard-source.out

Expand all Fold all

[PATCH v3 0/5] backup: discard-source parameter

Posted by Vladimir Sementsov-Ogievskiy 9 months ago

Hi all! The main patch is 04, please look at it for description and
diagram.

v3:
02: new patch
04: take WRITE permission only when discard_source is required

Vladimir Sementsov-Ogievskiy (5):
  block/copy-before-write: fix permission
  block/copy-before-write: support unligned snapshot-discard
  block/copy-before-write: create block_copy bitmap in filter node
  qapi: blockdev-backup: add discard-source parameter
  iotests: add backup-discard-source

 block/backup.c                                |   5 +-
 block/block-copy.c                            |  12 +-
 block/copy-before-write.c                     |  39 ++++-
 block/copy-before-write.h                     |   1 +
 block/replication.c                           |   4 +-
 blockdev.c                                    |   2 +-
 include/block/block-common.h                  |   2 +
 include/block/block-copy.h                    |   2 +
 include/block/block_int-global-state.h        |   2 +-
 qapi/block-core.json                          |   4 +
 tests/qemu-iotests/257.out                    | 112 ++++++-------
 .../qemu-iotests/tests/backup-discard-source  | 151 ++++++++++++++++++
 .../tests/backup-discard-source.out           |   5 +
 13 files changed, 271 insertions(+), 70 deletions(-)
 create mode 100755 tests/qemu-iotests/tests/backup-discard-source
 create mode 100644 tests/qemu-iotests/tests/backup-discard-source.out

-- 
2.34.1

Re: [PATCH v3 0/5] backup: discard-source parameter

Posted by Fiona Ebner 8 months, 3 weeks ago

Am 28.02.24 um 15:14 schrieb Vladimir Sementsov-Ogievskiy:
> Hi all! The main patch is 04, please look at it for description and
> diagram.
> 
> v3:
> 02: new patch
> 04: take WRITE permission only when discard_source is required
> 
> Vladimir Sementsov-Ogievskiy (5):
>   block/copy-before-write: fix permission
>   block/copy-before-write: support unligned snapshot-discard
>   block/copy-before-write: create block_copy bitmap in filter node
>   qapi: blockdev-backup: add discard-source parameter
>   iotests: add backup-discard-source
> 
>  block/backup.c                                |   5 +-
>  block/block-copy.c                            |  12 +-
>  block/copy-before-write.c                     |  39 ++++-
>  block/copy-before-write.h                     |   1 +
>  block/replication.c                           |   4 +-
>  blockdev.c                                    |   2 +-
>  include/block/block-common.h                  |   2 +
>  include/block/block-copy.h                    |   2 +
>  include/block/block_int-global-state.h        |   2 +-
>  qapi/block-core.json                          |   4 +
>  tests/qemu-iotests/257.out                    | 112 ++++++-------
>  .../qemu-iotests/tests/backup-discard-source  | 151 ++++++++++++++++++
>  .../tests/backup-discard-source.out           |   5 +
>  13 files changed, 271 insertions(+), 70 deletions(-)
>  create mode 100755 tests/qemu-iotests/tests/backup-discard-source
>  create mode 100644 tests/qemu-iotests/tests/backup-discard-source.out
> 

Tested-by: Fiona Ebner <f.ebner@proxmox.com>