Revert "hw/i386/pc: Confine system flash handling to pc_sysfw"

[PATCH 0/2] Revert "hw/i386/pc: Confine system flash handling to pc_sysfw"

Posted by Bernhard Beschow 3 months, 2 weeks ago

As reported by Volker [1], commit 6f6ad2b24582 "hw/i386/pc: Confine system
flash handling to pc_sysfw" causes a regression when specifying the property
`-M pflash0` in the PCI PC machines:
  qemu-system-x86_64: Property 'pc-q35-9.0-machine.pflash0' not found
Revert the commit for now until a solution is found.

Best regards,
Bernhard

[1] https://lore.kernel.org/qemu-devel/9e82a04b-f2c1-4e34-b4b6-46a0581b572f@t-online.de/

Bernhard Beschow (2):
  Revert "hw/i386/pc_sysfw: Inline pc_system_flash_create() and remove
    it"
  Revert "hw/i386/pc: Confine system flash handling to pc_sysfw"

 include/hw/i386/pc.h |  2 ++
 hw/i386/pc.c         |  1 +
 hw/i386/pc_piix.c    |  1 +
 hw/i386/pc_sysfw.c   | 17 +++++++++++++----
 4 files changed, 17 insertions(+), 4 deletions(-)

-- 
2.44.0

Re: [PATCH 0/2] Revert "hw/i386/pc: Confine system flash handling to pc_sysfw"

Posted by Alex Williamson 3 months, 1 week ago

On Mon, 26 Feb 2024 22:59:07 +0100
Bernhard Beschow <shentey@gmail.com> wrote:

> As reported by Volker [1], commit 6f6ad2b24582 "hw/i386/pc: Confine system
> flash handling to pc_sysfw" causes a regression when specifying the property
> `-M pflash0` in the PCI PC machines:
>   qemu-system-x86_64: Property 'pc-q35-9.0-machine.pflash0' not found
> Revert the commit for now until a solution is found.
> 
> Best regards,
> Bernhard
> 
> [1] https://lore.kernel.org/qemu-devel/9e82a04b-f2c1-4e34-b4b6-46a0581b572f@t-online.de/
> 
> Bernhard Beschow (2):
>   Revert "hw/i386/pc_sysfw: Inline pc_system_flash_create() and remove
>     it"
>   Revert "hw/i386/pc: Confine system flash handling to pc_sysfw"
> 
>  include/hw/i386/pc.h |  2 ++
>  hw/i386/pc.c         |  1 +
>  hw/i386/pc_piix.c    |  1 +
>  hw/i386/pc_sysfw.c   | 17 +++++++++++++----
>  4 files changed, 17 insertions(+), 4 deletions(-)
> 

Please apply this, the original commits break my existing VMs.

Tested-by: Alex Williamson <alex.williamson@redhat.com>

Re: [PATCH 0/2] Revert "hw/i386/pc: Confine system flash handling to pc_sysfw"

Posted by Bernhard Beschow 3 months, 2 weeks ago


Am 26. Februar 2024 21:59:07 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
>As reported by Volker [1], commit 6f6ad2b24582 "hw/i386/pc: Confine system
>
>flash handling to pc_sysfw" causes a regression when specifying the property
>
>`-M pflash0` in the PCI PC machines:
>
>  qemu-system-x86_64: Property 'pc-q35-9.0-machine.pflash0' not found
>
>Revert the commit for now until a solution is found.
>

Ping

>
>
>Best regards,
>
>Bernhard
>
>
>
>[1] https://lore.kernel.org/qemu-devel/9e82a04b-f2c1-4e34-b4b6-46a0581b572f@t-online.de/
>
>
>
>Bernhard Beschow (2):
>
>  Revert "hw/i386/pc_sysfw: Inline pc_system_flash_create() and remove
>
>    it"
>
>  Revert "hw/i386/pc: Confine system flash handling to pc_sysfw"
>
>
>
> include/hw/i386/pc.h |  2 ++
>
> hw/i386/pc.c         |  1 +
>
> hw/i386/pc_piix.c    |  1 +
>
> hw/i386/pc_sysfw.c   | 17 +++++++++++++----
>
> 4 files changed, 17 insertions(+), 4 deletions(-)
>
>
>
>-- >
>2.44.0
>
>
>

Re: [PATCH 0/2] Revert "hw/i386/pc: Confine system flash handling to pc_sysfw"

Posted by Michael S. Tsirkin 3 months, 2 weeks ago

On Thu, Feb 29, 2024 at 07:38:06PM +0000, Bernhard Beschow wrote:
> 
> 
> Am 26. Februar 2024 21:59:07 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
> >As reported by Volker [1], commit 6f6ad2b24582 "hw/i386/pc: Confine system
> >
> >flash handling to pc_sysfw" causes a regression when specifying the property
> >
> >`-M pflash0` in the PCI PC machines:
> >
> >  qemu-system-x86_64: Property 'pc-q35-9.0-machine.pflash0' not found
> >
> >Revert the commit for now until a solution is found.
> >
> 
> Ping

tagged, thanks!

> >
> >
> >Best regards,
> >
> >Bernhard
> >
> >
> >
> >[1] https://lore.kernel.org/qemu-devel/9e82a04b-f2c1-4e34-b4b6-46a0581b572f@t-online.de/
> >
> >
> >
> >Bernhard Beschow (2):
> >
> >  Revert "hw/i386/pc_sysfw: Inline pc_system_flash_create() and remove
> >
> >    it"
> >
> >  Revert "hw/i386/pc: Confine system flash handling to pc_sysfw"
> >
> >
> >
> > include/hw/i386/pc.h |  2 ++
> >
> > hw/i386/pc.c         |  1 +
> >
> > hw/i386/pc_piix.c    |  1 +
> >
> > hw/i386/pc_sysfw.c   | 17 +++++++++++++----
> >
> > 4 files changed, 17 insertions(+), 4 deletions(-)
> >
> >
> >
> >-- >
> >2.44.0
> >
> >
> >