include/hw/ide/internal.h | 8 +++----- include/sysemu/sysemu.h | 1 - hw/ide/core.c | 43 ++++++++++++++++++--------------------- hw/ide/qdev.c | 6 ++---- system/globals.c | 1 - system/vl.c | 2 +- qemu-options.hx | 3 ++- 7 files changed, 28 insertions(+), 36 deletions(-)
As per $SUBJECT, one less global and one more syntactic sugar property. Like -no-fd-bootchk, this could be deprecated but it can be done separately---and would slightly worsen documentation, so I'm leaving it aside for now. Paolo Paolo Bonzini (2): ide: collapse parameters to ide_init_drive ide, vl: turn -win2k-hack into a property on IDE devices include/hw/ide/internal.h | 8 +++----- include/sysemu/sysemu.h | 1 - hw/ide/core.c | 43 ++++++++++++++++++--------------------- hw/ide/qdev.c | 6 ++---- system/globals.c | 1 - system/vl.c | 2 +- qemu-options.hx | 3 ++- 7 files changed, 28 insertions(+), 36 deletions(-) -- 2.43.2
26.02.2024 11:29, Paolo Bonzini wrote: > As per $SUBJECT, one less global and one more syntactic sugar property. > Like -no-fd-bootchk, this could be deprecated but it can be done > separately---and would slightly worsen documentation, so I'm leaving > it aside for now. At this time, I don't think touching these options is a good thing. On one hand, it is all over the internet, suggested when some old OS doesn't work. On another hand, these aren't used often these days. This particular option isn't necessary with windows 2000, at least with two different kits of it which I have locally. So finding the thing when you actually need it (if it gets moved elsewhere) will be difficult. On yet another, the code to handle this stuff is small enough and does not require much to maintain, -- at least for now, maybe in future it will be more difficult. Thanks, /mjt
On Mon, Feb 26, 2024 at 10:24 AM Michael Tokarev <mjt@tls.msk.ru> wrote: > On another hand, these aren't used often these days. This particular > option isn't necessary with windows 2000, at least with two different > kits of it which I have locally. So finding the thing when you actually > need it (if it gets moved elsewhere) will be difficult. > > On yet another, the code to handle this stuff is small enough and does > not require much to maintain, -- at least for now, maybe in future it > will be more difficult. Yes, I agree. The purpose of these patches is to keep the implementation of the options separate from the implementation of the workaround, and that makes things even simpler. Paolo
On 26/2/24 09:29, Paolo Bonzini wrote: > As per $SUBJECT, one less global and one more syntactic sugar property. > Like -no-fd-bootchk, this could be deprecated but it can be done > separately---and would slightly worsen documentation, so I'm leaving > it aside for now. > > Paolo > > Paolo Bonzini (2): > ide: collapse parameters to ide_init_drive > ide, vl: turn -win2k-hack into a property on IDE devices Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> (This series will be queued in 24h)
On 26/2/24 09:45, Philippe Mathieu-Daudé wrote: > On 26/2/24 09:29, Paolo Bonzini wrote: >> As per $SUBJECT, one less global and one more syntactic sugar property. >> Like -no-fd-bootchk, this could be deprecated but it can be done >> separately---and would slightly worsen documentation, so I'm leaving >> it aside for now. >> >> Paolo >> >> Paolo Bonzini (2): >> ide: collapse parameters to ide_init_drive >> ide, vl: turn -win2k-hack into a property on IDE devices > > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > > (This series will be queued in 24h) Need a rebase :/
On Mon, Feb 26, 2024 at 9:50 AM Philippe Mathieu-Daudé <philmd@linaro.org> wrote: > On 26/2/24 09:45, Philippe Mathieu-Daudé wrote: > > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > > > > (This series will be queued in 24h) > > Need a rebase :/ The include/hw/ide/internal.h hunks simply have to move to include/hw/ide/ide-dev.h. I'll send a pull request myself, thanks for the review! Paolo
© 2016 - 2024 Red Hat, Inc.