test-util-sockets leaves the temporary socket files around in the
temporary files folder. Let's better remove them at the end of the
testing.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/unit/test-util-sockets.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/unit/test-util-sockets.c b/tests/unit/test-util-sockets.c
index 63909ccb2b..4c9dd0b271 100644
--- a/tests/unit/test-util-sockets.c
+++ b/tests/unit/test-util-sockets.c
@@ -326,6 +326,7 @@ static void test_socket_unix_abstract(void)
         test_socket_unix_abstract_row(&matrix[i]);
     }
 
+    unlink(addr.u.q_unix.path);
     g_free(addr.u.q_unix.path);
 }
 
-- 
2.43.2

26.02.2024 11:27, Thomas Huth wrote:
> test-util-sockets leaves the temporary socket files around in the
> temporary files folder. Let's better remove them at the end of the
> testing.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/unit/test-util-sockets.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/unit/test-util-sockets.c b/tests/unit/test-util-sockets.c
> index 63909ccb2b..4c9dd0b271 100644
> --- a/tests/unit/test-util-sockets.c
> +++ b/tests/unit/test-util-sockets.c
> @@ -326,6 +326,7 @@ static void test_socket_unix_abstract(void)
>           test_socket_unix_abstract_row(&matrix[i]);
>       }
>   
> +    unlink(addr.u.q_unix.path);
>       g_free(addr.u.q_unix.path);
>   }

Added the Fixes: tag as suggested by Philippe, and queued to trivial-patches
tree.  Thank you Thomas for this thankless work!

/mjt

On 26/2/24 09:27, Thomas Huth wrote:
> test-util-sockets leaves the temporary socket files around in the
> temporary files folder. Let's better remove them at the end of the
> testing.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/unit/test-util-sockets.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/unit/test-util-sockets.c b/tests/unit/test-util-sockets.c
> index 63909ccb2b..4c9dd0b271 100644
> --- a/tests/unit/test-util-sockets.c
> +++ b/tests/unit/test-util-sockets.c
> @@ -326,6 +326,7 @@ static void test_socket_unix_abstract(void)
>           test_socket_unix_abstract_row(&matrix[i]);
>       }
>   
> +    unlink(addr.u.q_unix.path);
>       g_free(addr.u.q_unix.path);
>   }
>   

Maybe:
Fixes: 4d3a329af5 ("tests/util-sockets: add abstract unix socket cases")

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

On Mon, Feb 26, 2024 at 12:28 PM Thomas Huth <thuth@redhat.com> wrote:
>
> test-util-sockets leaves the temporary socket files around in the
> temporary files folder. Let's better remove them at the end of the
> testing.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  tests/unit/test-util-sockets.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/unit/test-util-sockets.c b/tests/unit/test-util-sockets.c
> index 63909ccb2b..4c9dd0b271 100644
> --- a/tests/unit/test-util-sockets.c
> +++ b/tests/unit/test-util-sockets.c
> @@ -326,6 +326,7 @@ static void test_socket_unix_abstract(void)
>          test_socket_unix_abstract_row(&matrix[i]);
>      }
>
> +    unlink(addr.u.q_unix.path);
>      g_free(addr.u.q_unix.path);
>  }
>
> --
> 2.43.2
>
>


-- 
Marc-André Lureau