[v3] hw/ide: Make "ide_internal.h" really internal

[PATCH v3 0/3] hw/ide: Make "ide_internal.h" really internal

Philippe Mathieu-Daudé posted 3 patches 9 months ago

Diff against v1 v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240226080632.9596-1-philmd@linaro.org

Maintainers: Radoslaw Biernacki <rad@semihalf.com>, Peter Maydell <peter.maydell@linaro.org>, Leif Lindholm <quic_llindhol@quicinc.com>, Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>, John Snow <jsnow@redhat.com>, BALATON Zoltan <balaton@eik.bme.hu>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

hw/ide/ahci_internal.h                             |  2 +-
include/hw/ide/internal.h => hw/ide/ide-internal.h |  0
include/hw/misc/macio/macio.h                      |  2 +-
hw/arm/sbsa-ref.c                                  | 13 ++-----------
hw/ide/ahci.c                                      |  2 +-
hw/ide/atapi.c                                     |  2 +-
hw/ide/cmd646.c                                    |  2 +-
hw/ide/core.c                                      |  2 +-
hw/ide/ide-bus.c                                   |  2 +-
hw/ide/ide-dev.c                                   |  2 +-
hw/ide/ioport.c                                    |  2 +-
hw/ide/isa.c                                       |  2 +-
hw/ide/macio.c                                     |  2 +-
hw/ide/microdrive.c                                |  2 +-
hw/ide/mmio.c                                      |  2 +-
hw/ide/pci.c                                       |  2 +-
hw/ide/piix.c                                      |  2 +-
hw/ide/sii3112.c                                   |  2 +-
hw/ide/via.c                                       |  2 +-
19 files changed, 19 insertions(+), 28 deletions(-)
rename include/hw/ide/internal.h => hw/ide/ide-internal.h (100%)

Expand all Fold all

[PATCH v3 0/3] hw/ide: Make "ide_internal.h" really internal

Posted by Philippe Mathieu-Daudé 9 months ago

Missing review: 3

Since v2:
- Remove local 'ahci' variable
- Rename "ide_internal.h" -> "ide-internal.h" (Zoltan)

Since v1:
- Remove use of "ahci_internal.h" in SBSA-Ref
- Rename "internal.h" -> "ide_internal.h"

Supersedes: <20240223142633.933694E6004@zero.eik.bme.hu>

BALATON Zoltan (1):
  hw/ide: Remove last two uses of ide/internal.h outside of hw/ide/

Philippe Mathieu-Daudé (2):
  hw/arm/sbsa-ref: Do not open-code ahci_ide_create_devs()
  hw/ide: Include 'ide_internal.h' from current path

 hw/ide/ahci_internal.h                             |  2 +-
 include/hw/ide/internal.h => hw/ide/ide-internal.h |  0
 include/hw/misc/macio/macio.h                      |  2 +-
 hw/arm/sbsa-ref.c                                  | 13 ++-----------
 hw/ide/ahci.c                                      |  2 +-
 hw/ide/atapi.c                                     |  2 +-
 hw/ide/cmd646.c                                    |  2 +-
 hw/ide/core.c                                      |  2 +-
 hw/ide/ide-bus.c                                   |  2 +-
 hw/ide/ide-dev.c                                   |  2 +-
 hw/ide/ioport.c                                    |  2 +-
 hw/ide/isa.c                                       |  2 +-
 hw/ide/macio.c                                     |  2 +-
 hw/ide/microdrive.c                                |  2 +-
 hw/ide/mmio.c                                      |  2 +-
 hw/ide/pci.c                                       |  2 +-
 hw/ide/piix.c                                      |  2 +-
 hw/ide/sii3112.c                                   |  2 +-
 hw/ide/via.c                                       |  2 +-
 19 files changed, 19 insertions(+), 28 deletions(-)
 rename include/hw/ide/internal.h => hw/ide/ide-internal.h (100%)

-- 
2.41.0

Re: [PATCH v3 0/3] hw/ide: Make "ide_internal.h" really internal

Posted by Philippe Mathieu-Daudé 9 months ago

On 26/2/24 09:06, Philippe Mathieu-Daudé wrote:
> Missing review: 3

> BALATON Zoltan (1):
>    hw/ide: Remove last two uses of ide/internal.h outside of hw/ide/
> 
> Philippe Mathieu-Daudé (2):
>    hw/arm/sbsa-ref: Do not open-code ahci_ide_create_devs()
>    hw/ide: Include 'ide_internal.h' from current path

Series queued.