[PATCH v2 2/2] system/vl: Update description for input grab key

Tianlan Zhou posted 2 patches 9 months, 1 week ago
Maintainers: Paolo Bonzini <pbonzini@redhat.com>
[PATCH v2 2/2] system/vl: Update description for input grab key
Posted by Tianlan Zhou 9 months, 1 week ago
Input grab key should be Ctrl-Alt-g, not just Ctrl-Alt.

Signed-off-by: Tianlan Zhou <bobby825@126.com>
---
 system/vl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/system/vl.c b/system/vl.c
index a82555ae15..b8469d9965 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -891,7 +891,7 @@ static void help(int exitcode)
     printf("\nDuring emulation, the following keys are useful:\n"
            "ctrl-alt-f      toggle full screen\n"
            "ctrl-alt-n      switch to virtual console 'n'\n"
-           "ctrl-alt        toggle mouse and keyboard grab\n"
+           "ctrl-alt-g      toggle mouse and keyboard grab\n"
            "\n"
            "When using -nographic, press 'ctrl-a h' to get some help.\n"
            "\n"
-- 
2.38.1.windows.1
Re: [PATCH v2 2/2] system/vl: Update description for input grab key
Posted by Tianlan Zhou 9 months, 1 week ago
Cc qemu-stable, as this will fix the `qemu-system-xxx -h` help message.


On 2024/2/22 3:52, Tianlan Zhou wrote:
> Input grab key should be Ctrl-Alt-g, not just Ctrl-Alt.
> 
> Signed-off-by: Tianlan Zhou <bobby825@126.com>
> ---
>  system/vl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/system/vl.c b/system/vl.c
> index a82555ae15..b8469d9965 100644
> --- a/system/vl.c
> +++ b/system/vl.c
> @@ -891,7 +891,7 @@ static void help(int exitcode)
>      printf("\nDuring emulation, the following keys are useful:\n"
>             "ctrl-alt-f      toggle full screen\n"
>             "ctrl-alt-n      switch to virtual console 'n'\n"
> -           "ctrl-alt        toggle mouse and keyboard grab\n"
> +           "ctrl-alt-g      toggle mouse and keyboard grab\n"
>             "\n"
>             "When using -nographic, press 'ctrl-a h' to get some help.\n"
>             "\n"
> -- 
> 2.38.1.windows.1
Re: [PATCH v2 2/2] system/vl: Update description for input grab key
Posted by Michael Tokarev 9 months, 1 week ago
22.02.2024 15:50, Tianlan Zhou wrote:
> Cc qemu-stable, as this will fix the `qemu-system-xxx -h` help message.

Yes, I already picked up both of them.

/mjt
Re: [PATCH v2 2/2] system/vl: Update description for input grab key
Posted by Thomas Huth 9 months, 1 week ago
On 21/02/2024 20.52, Tianlan Zhou wrote:
> Input grab key should be Ctrl-Alt-g, not just Ctrl-Alt.
> 
> Signed-off-by: Tianlan Zhou <bobby825@126.com>
> ---
>   system/vl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/system/vl.c b/system/vl.c
> index a82555ae15..b8469d9965 100644
> --- a/system/vl.c
> +++ b/system/vl.c
> @@ -891,7 +891,7 @@ static void help(int exitcode)
>       printf("\nDuring emulation, the following keys are useful:\n"
>              "ctrl-alt-f      toggle full screen\n"
>              "ctrl-alt-n      switch to virtual console 'n'\n"
> -           "ctrl-alt        toggle mouse and keyboard grab\n"
> +           "ctrl-alt-g      toggle mouse and keyboard grab\n"
>              "\n"
>              "When using -nographic, press 'ctrl-a h' to get some help.\n"
>              "\n"

Fixes: f8d2c9369b ("sdl: use ctrl-alt-g as grab hotkey")

Reviewed-by: Thomas Huth <thuth@redhat.com>