[PATCH] docs/system: Fix key for input grab

Tianlan Zhou posted 1 patch 9 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240221131900.2041-1-bobby825@126.com
docs/system/keys.rst.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] docs/system: Fix key for input grab
Posted by Tianlan Zhou 9 months, 1 week ago
Key for input grab should be Ctrl-Alt-g, not just Ctrl-Alt.

Signed-off-by: Tianlan Zhou <bobby825@126.com>
---

v1:
- Initial patch

---
 docs/system/keys.rst.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/system/keys.rst.inc b/docs/system/keys.rst.inc
index 2e2c97aa23..59966a3fe7 100644
--- a/docs/system/keys.rst.inc
+++ b/docs/system/keys.rst.inc
@@ -29,7 +29,7 @@ Ctrl-Alt-n
    *3*
       Serial port
 
-Ctrl-Alt
+Ctrl-Alt-g
    Toggle mouse and keyboard grab.
 
 In the virtual consoles, you can use Ctrl-Up, Ctrl-Down, Ctrl-PageUp and
-- 
2.38.1.windows.1
Re: [PATCH] docs/system: Fix key for input grab
Posted by Alex Bennée 9 months, 1 week ago
Tianlan Zhou <bobby825@126.com> writes:

> Key for input grab should be Ctrl-Alt-g, not just Ctrl-Alt.
>
> Signed-off-by: Tianlan Zhou <bobby825@126.com>
> ---
>
> v1:
> - Initial patch
>
> ---
>  docs/system/keys.rst.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/system/keys.rst.inc b/docs/system/keys.rst.inc
> index 2e2c97aa23..59966a3fe7 100644
> --- a/docs/system/keys.rst.inc
> +++ b/docs/system/keys.rst.inc
> @@ -29,7 +29,7 @@ Ctrl-Alt-n
>     *3*
>        Serial port
>  
> -Ctrl-Alt
> +Ctrl-Alt-g
>     Toggle mouse and keyboard grab.

I think this is correct although I notice we also echo this advice in
the vl help text:

#include "qemu-options.def"

    printf("\nDuring emulation, the following keys are useful:\n"
           "ctrl-alt-f      toggle full screen\n"
           "ctrl-alt-n      switch to virtual console 'n'\n"
           "ctrl-alt        toggle mouse and keyboard grab\n"
           "\n"
           "When using -nographic, press 'ctrl-a h' to get some help.\n"
           "\n"
           QEMU_HELP_BOTTOM "\n");

    exit(exitcode);


>  
>  In the virtual consoles, you can use Ctrl-Up, Ctrl-Down, Ctrl-PageUp and

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro