qga-win: Add support of Windows Server 2025 in get-osinfo command

[PATCH] qga-win: Add support of Windows Server 2025 in get-osinfo command

Posted by Dehan Meng 9 months, 1 week ago

Add support of Windows Server 2025 in get-osinfo command

Signed-off-by: Dehan Meng <demeng@redhat.com>
---
 qga/commands-win32.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 697c65507c..f3c7e604c9 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -2154,6 +2154,7 @@ static ga_win_10_0_t const WIN_10_0_SERVER_VERSION_MATRIX[4] = {
     {14393, "Microsoft Windows Server 2016",    "2016"},
     {17763, "Microsoft Windows Server 2019",    "2019"},
     {20344, "Microsoft Windows Server 2022",    "2022"},
+    {26040, "MIcrosoft Windows Server 2025",    "2025"},
     {0, 0}
 };
 
-- 
2.35.1

Re: [PATCH] qga-win: Add support of Windows Server 2025 in get-osinfo command

Posted by Konstantin Kostiuk 9 months, 1 week ago

On Wed, Feb 21, 2024 at 11:51 AM Dehan Meng <demeng@redhat.com> wrote:

> Add support of Windows Server 2025 in get-osinfo command
>
> Signed-off-by: Dehan Meng <demeng@redhat.com>
> ---
>  qga/commands-win32.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
> index 697c65507c..f3c7e604c9 100644
> --- a/qga/commands-win32.c
> +++ b/qga/commands-win32.c
> @@ -2154,6 +2154,7 @@ static ga_win_10_0_t const
> WIN_10_0_SERVER_VERSION_MATRIX[4] = {
>

You don't update the array size, there are out of range elements


>      {14393, "Microsoft Windows Server 2016",    "2016"},
>      {17763, "Microsoft Windows Server 2019",    "2019"},
>      {20344, "Microsoft Windows Server 2022",    "2022"},
> +    {26040, "MIcrosoft Windows Server 2025",    "2025"},
>      {0, 0}
>  };
>
> --
> 2.35.1
>
>

Re: [PATCH] qga-win: Add support of Windows Server 2025 in get-osinfo command

Posted by Dehan Meng 9 months, 1 week ago

Done. thanks.

On Wed, Feb 21, 2024 at 6:00 PM Konstantin Kostiuk <kkostiuk@redhat.com>
wrote:

>
>
> On Wed, Feb 21, 2024 at 11:51 AM Dehan Meng <demeng@redhat.com> wrote:
>
>> Add support of Windows Server 2025 in get-osinfo command
>>
>> Signed-off-by: Dehan Meng <demeng@redhat.com>
>> ---
>>  qga/commands-win32.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
>> index 697c65507c..f3c7e604c9 100644
>> --- a/qga/commands-win32.c
>> +++ b/qga/commands-win32.c
>> @@ -2154,6 +2154,7 @@ static ga_win_10_0_t const
>> WIN_10_0_SERVER_VERSION_MATRIX[4] = {
>>
>
> You don't update the array size, there are out of range elements
>
>
>>      {14393, "Microsoft Windows Server 2016",    "2016"},
>>      {17763, "Microsoft Windows Server 2019",    "2019"},
>>      {20344, "Microsoft Windows Server 2022",    "2022"},
>> +    {26040, "MIcrosoft Windows Server 2025",    "2025"},
>>      {0, 0}
>>  };
>>
>> --
>> 2.35.1
>>
>>