This patch series implements support for the Broadcom Serial Controller used
by BCM2835 based boards for I2C.

[Changes in v3]

- Add SPDX license identifiers.
- Fix a few minor whitespace issues.

[Changes in v2]

- Fixed and simplified writing to status register

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/481
Signed-off-by: Rayhan Faizel <rayhan.faizel@gmail.com>

Rayhan Faizel (3):
  hw/i2c: Implement Broadcom Serial Controller (BSC)
  hw/arm: Connect BSC to BCM2835 board as I2C0, I2C1 and I2C2
  tests/qtest: Add testcase for BCM2835 BSC

 docs/system/arm/raspi.rst            |   1 +
 hw/arm/Kconfig                       |   1 +
 hw/arm/bcm2835_peripherals.c         |  32 ++-
 hw/i2c/Kconfig                       |   4 +
 hw/i2c/bcm2835_i2c.c                 | 278 +++++++++++++++++++++++++++
 hw/i2c/meson.build                   |   1 +
 include/hw/arm/bcm2835_peripherals.h |   3 +-
 include/hw/i2c/bcm2835_i2c.h         |  80 ++++++++
 tests/qtest/bcm2835-i2c-test.c       | 107 +++++++++++
 tests/qtest/meson.build              |   2 +-
 10 files changed, 504 insertions(+), 5 deletions(-)
 create mode 100644 hw/i2c/bcm2835_i2c.c
 create mode 100644 include/hw/i2c/bcm2835_i2c.h
 create mode 100644 tests/qtest/bcm2835-i2c-test.c

-- 
2.34.1

On Tue, 20 Feb 2024 at 13:42, Rayhan Faizel <rayhan.faizel@gmail.com> wrote:
>
> This patch series implements support for the Broadcom Serial Controller used
> by BCM2835 based boards for I2C.
>
> [Changes in v3]
>
> - Add SPDX license identifiers.
> - Fix a few minor whitespace issues.
>
> [Changes in v2]
>
> - Fixed and simplified writing to status register
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/481
> Signed-off-by: Rayhan Faizel <rayhan.faizel@gmail.com>
>
> Rayhan Faizel (3):
>   hw/i2c: Implement Broadcom Serial Controller (BSC)
>   hw/arm: Connect BSC to BCM2835 board as I2C0, I2C1 and I2C2
>   tests/qtest: Add testcase for BCM2835 BSC



Applied to target-arm.next, thanks.

-- PMM

Hi Peter,

On 22/2/24 18:54, Peter Maydell wrote:
> On Tue, 20 Feb 2024 at 13:42, Rayhan Faizel <rayhan.faizel@gmail.com> wrote:
>>
>> This patch series implements support for the Broadcom Serial Controller used
>> by BCM2835 based boards for I2C.


>> Rayhan Faizel (3):
>>    hw/i2c: Implement Broadcom Serial Controller (BSC)
>>    hw/arm: Connect BSC to BCM2835 board as I2C0, I2C1 and I2C2
>>    tests/qtest: Add testcase for BCM2835 BSC
> 
> 
> 
> Applied to target-arm.next, thanks.

Sorry I didn't notice earlier, the I2C[3] IRQ lines have
to be OR-ed using a TYPE_OR_IRQ object before reaching the
INTC. I'd rather a v4, but if you already posted your PR
this can get fixed on top.

Regards,

Phil.

On Fri, 23 Feb 2024 at 06:23, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Hi Peter,
>
> On 22/2/24 18:54, Peter Maydell wrote:
> > On Tue, 20 Feb 2024 at 13:42, Rayhan Faizel <rayhan.faizel@gmail.com> wrote:
> >>
> >> This patch series implements support for the Broadcom Serial Controller used
> >> by BCM2835 based boards for I2C.
>
>
> >> Rayhan Faizel (3):
> >>    hw/i2c: Implement Broadcom Serial Controller (BSC)
> >>    hw/arm: Connect BSC to BCM2835 board as I2C0, I2C1 and I2C2
> >>    tests/qtest: Add testcase for BCM2835 BSC
> >
> >
> >
> > Applied to target-arm.next, thanks.
>
> Sorry I didn't notice earlier, the I2C[3] IRQ lines have
> to be OR-ed using a TYPE_OR_IRQ object before reaching the
> INTC. I'd rather a v4, but if you already posted your PR
> this can get fixed on top.

Oops, yes, you're right. I didn't notice that. I haven't yet
got to the point of making a pullreq, so I'll drop this series,
and send my r-by tags to the list for the other patches.

thanks
-- PMM